From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, stable@vger.kernel.org,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH] efi: random: zero out secret after use and do not take minimum
Date: Thu, 17 Nov 2022 01:31:20 +0100 [thread overview]
Message-ID: <Y3WA2BU0vtsOu6pJ@zx2c4.com> (raw)
In-Reply-To: <CAMj1kXHJ4vQ=2dnJCAR1eOaM9FPvokYb_DODu+3MAR7XMMQ7fw@mail.gmail.com>
On Wed, Nov 16, 2022 at 10:44:20PM +0100, Ard Biesheuvel wrote:
> On Wed, 16 Nov 2022 at 21:06, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> >
> > Taking the minimum is wrong, if the bootloader or EFI stub is actually
> > passing on a bunch of bytes that it expects the kernel to hash itself.
>
> We still need some kind of limit, just so things don't explode if
> seed->size is bogus.
Alright, let's just say 1k then. Will send a v2.
Jason
next prev parent reply other threads:[~2022-11-17 0:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 20:05 [PATCH] efi: random: zero out secret after use and do not take minimum Jason A. Donenfeld
2022-11-16 21:44 ` Ard Biesheuvel
2022-11-17 0:31 ` Jason A. Donenfeld [this message]
2022-11-17 0:39 ` [PATCH v2] " Jason A. Donenfeld
2022-11-18 8:39 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3WA2BU0vtsOu6pJ@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox