From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E40C47088 for ; Mon, 5 Dec 2022 15:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232470AbiLEPIn (ORCPT ); Mon, 5 Dec 2022 10:08:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232479AbiLEPIS (ORCPT ); Mon, 5 Dec 2022 10:08:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C8BAD2DD; Mon, 5 Dec 2022 07:08:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0EEF16119A; Mon, 5 Dec 2022 15:08:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CC75C433C1; Mon, 5 Dec 2022 15:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670252891; bh=aD976dpLSZrvdiKPkzTWfbT9kaCjs86wvXYu3RuxCCk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xlcLTyRQ6xy0wl3AemTDT+u71655K6rCFAj0bvuVQWUcQOmF+vGRizu6l22wgiJRz h/31CdhQKy1S1RjvzV7jufjua9luJpCdvVWRiJle24Rom0o97GcQxxqeCA/Rz+4XWx L0EoH8wNwwP1hxWJSn8Si4T/KTycBKZ8kOh84CHA= Date: Mon, 5 Dec 2022 16:08:08 +0100 From: Greg Kroah-Hartman To: Ming Lei Cc: stable@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, Shiwei Cui , Christoph Hellwig , Jan Kara Subject: Re: [PATCH 5.10.y stable v2] block: unhash blkdev part inode when the part is deleted Message-ID: References: <20221205132739.844399-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221205132739.844399-1-ming.lei@redhat.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Dec 05, 2022 at 09:27:39PM +0800, Ming Lei wrote: > v5.11 changes the blkdev lookup mechanism completely since commit > 22ae8ce8b892 ("block: simplify bdev/disk lookup in blkdev_get"), > and small part of the change is to unhash part bdev inode when > deleting partition. Turns out this kind of change does fix one > nasty issue in case of BLOCK_EXT_MAJOR: > > 1) when one partition is deleted & closed, disk_put_part() is always > called before bdput(bdev), see blkdev_put(); so the part's devt can > be freed & re-used before the inode is dropped > > 2) then new partition with same devt can be created just before the > inode in 1) is dropped, then the old inode/bdev structurein 1) is > re-used for this new partition, this way causes use-after-free and > kernel panic. > > It isn't possible to backport the whole big patchset of "merge struct > block_device and struct hd_struct v4" for addressing this issue. > > https://lore.kernel.org/linux-block/20201128161510.347752-1-hch@lst.de/ > > So fixes it by unhashing part bdev in delete_partition(), and this way > is actually aligned with v5.11+'s behavior. > > Reported-by: Shiwei Cui > Tested-by: Shiwei Cui > Cc: Christoph Hellwig > Cc: Jan Kara > Signed-off-by: Ming Lei > --- > V2: > - fix one typo and Shiwei's email format > > block/partitions/core.c | 7 +++++++ I need an ack from the block maintainers/developers to be able to take this. thanks, greg k-h