From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF379C001B2 for ; Thu, 8 Dec 2022 20:22:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbiLHUWy (ORCPT ); Thu, 8 Dec 2022 15:22:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229886AbiLHUWt (ORCPT ); Thu, 8 Dec 2022 15:22:49 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9AD02B1B4 for ; Thu, 8 Dec 2022 12:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670530919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mMLxZ2vEpcan9FP4JPPeH3ALepfz4tDO6+Vi7LEQRvk=; b=gjAXwsfnCHE/keAGBiKhfX/Frye1MFNeB9C2/xfV89UtxU4XInvbPmJfrk48Pn1xLXv5pl N1PfcXOSR6NK2vrsad9hIE4WM9+JSh4s6SSjCuwjhyiHdEet1rmWtLLrULJqlsQWrle8Zc lVJEd635DcBJ8UUPEyyGKkaCnqe9Src= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-310-OI0A1ltGP6SFDqJz_K-eEQ-1; Thu, 08 Dec 2022 15:21:57 -0500 X-MC-Unique: OI0A1ltGP6SFDqJz_K-eEQ-1 Received: by mail-qk1-f198.google.com with SMTP id f13-20020a05620a408d00b006fc740f837eso2688283qko.20 for ; Thu, 08 Dec 2022 12:21:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mMLxZ2vEpcan9FP4JPPeH3ALepfz4tDO6+Vi7LEQRvk=; b=WZ9SkfCDiqG59I6n5hwoTSrasGtuVmcXzzbQ+4TGTkvbiQzmCMCZJa3moDQMRYFmwc Vx68/gX8zxjKkR2DrqZN0jKam8Q5njOzbw2YB6uH63L4Ej/k0yBuh+h4rVH1Wz10zj0w AWgVn4WykIyKTJsXeZ1+81ov8aHuHmUR39LwOHVLkfERWjZpK/HItRBhAYEYApOm67oG 2bVCYJpTHjad2Fx0Shhwfmq/XENjSFiLBCTgrEU6f+kHYqjhEVVvSLKIXNjZzYIXKVMg FVKv9BDoXSOL+4SyyoAdlmNNiFe9jehiMDeUrIChPSXBzuipax0+Y1typJIJL9l6c3Vw w2Kg== X-Gm-Message-State: ANoB5pn/83cAiwyVSf8vxl3RIbnZ6ZDpfycxQZtROHOev3HzLgiMOvoj XsUQl8t7EbQmi+6X9kXtttQW3DTjxsoT3QMV8SBl23JshJrxrnztJF8R5vdVHZ345Z3ror2Z6Rc gUcHNWlMq7Aob7mv+ X-Received: by 2002:ac8:774d:0:b0:3a5:7ab0:e1c4 with SMTP id g13-20020ac8774d000000b003a57ab0e1c4mr4517412qtu.35.1670530917388; Thu, 08 Dec 2022 12:21:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf7k+qy/zHCSKcSSKL+b4cS9+x4HXGI/lH5oy++Dhi9P840spOv4KDspGKt5GTP4hJO3hvBySw== X-Received: by 2002:ac8:774d:0:b0:3a5:7ab0:e1c4 with SMTP id g13-20020ac8774d000000b003a57ab0e1c4mr4517397qtu.35.1670530917146; Thu, 08 Dec 2022 12:21:57 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id ga23-20020a05622a591700b003a526675c07sm16021164qtb.52.2022.12.08.12.21.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 12:21:56 -0800 (PST) Date: Thu, 8 Dec 2022 15:21:55 -0500 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ives van Hoorne , stable@vger.kernel.org, Andrew Morton , Hugh Dickins , Alistair Popple , Mike Rapoport , Nadav Amit , Andrea Arcangeli Subject: Re: [PATCH v1] mm/userfaultfd: enable writenotify while userfaultfd-wp is enabled for a VMA Message-ID: References: <20221208114137.35035-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Dec 08, 2022 at 03:06:06PM -0500, Peter Xu wrote: > On Thu, Dec 08, 2022 at 05:44:35PM +0100, David Hildenbrand wrote: > > I'll wait for some more (+retest) before I resend tomorrow. > > One more thing just to double check: > > It's 6a56ccbcf6c6 ("mm/autonuma: use can_change_(pte|pmd)_writable() to > replace savedwrite", 2022-11-30) that just started to break uffd-wp on > numa, am I right? > > With the old code, pte_modify() will persist uffd-wp bit, afaict, and we > used to do savedwrite for numa hints. That all look correct to me until > the savedwrite removal patchset with/without vm_page_prot changes. > > If that's the case, we'd better also mention that in the commit message and > has another Fixes: for that one to be clear. Nah, never mind. I think the savedwrite will not guarantee pte write protected just like the migration path. The commit message is correct. -- Peter Xu