From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B535C4332F for ; Wed, 14 Dec 2022 00:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237258AbiLNAlu (ORCPT ); Tue, 13 Dec 2022 19:41:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237212AbiLNAl1 (ORCPT ); Tue, 13 Dec 2022 19:41:27 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4DF526AB9 for ; Tue, 13 Dec 2022 16:40:04 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id u5so5182224pjy.5 for ; Tue, 13 Dec 2022 16:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nMXSUhRQOxy7tEuvDry5hNPWkTeD3FTVDObnfkaZoqo=; b=BH7DsjF/MqmaFEQUpJolgTrbi5A6L62CZdhE1oKhBHXLTPvRwujfy44Po3BKotOOtC m/lc9V7LvPlO9oA27wvnJECyKmNVMhwkDkhRN8zaqNeFKRxXQasvUHU7Hpifj4SkNsFB T0zfj6yx9b7+7tQuqogJAof91yqJxBGMRoCLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nMXSUhRQOxy7tEuvDry5hNPWkTeD3FTVDObnfkaZoqo=; b=XIBJR92ptfQEE7Krwt/6fBtWh/VQShdU26Ln61DDb53KAUY/wQ5XXOjplfzd4DDX5w bBYKDc7LlJ8Pe6KI1IkU7ADgNsF2HeBs6naD2dqIwlHSWkKAAcupck3SCWLW//BC/IaB XzMgEriufYWSamQ/UwUtfIeBRJbvEhfjGGpTkEYw/2Ljd0PhSoI9XObaogzGW17ejNTH sr3dLmjjot6+L+e4DqcjsnJwHhtD4iEvxDxVYjkGgcsekteHSxsLSc7ADkzPbSb28Lgn AiOSR6T/VwCy4RWnb/uBfheMQiMsu6ilvhCxV8SeSIWwUAVUBPkd4Kby+D9jUbJnl0Xg KXbg== X-Gm-Message-State: ANoB5pnAM3+ODnMW5QADF1wm8B1vhv3y8u2yXLRIHJvMFTa09uImDN0o kbqQmoNqFM0uRFqc3Q1Qdv4otA== X-Google-Smtp-Source: AA0mqf4kSqVg4gnsl8RkfCPeORprvNaEXNUCBQeC70AsH6pnDWedTQ4tO9+n5cA43Z/m7cZ/ZT23ug== X-Received: by 2002:a17:902:d483:b0:189:ced9:a5ea with SMTP id c3-20020a170902d48300b00189ced9a5eamr29138799plg.27.1670978404367; Tue, 13 Dec 2022 16:40:04 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id w1-20020a170902e88100b00186a2444a43sm510077plg.27.2022.12.13.16.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 16:40:03 -0800 (PST) Date: Wed, 14 Dec 2022 09:39:58 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Max Staudt , Sergey Senozhatsky , Yunke Cao , Laurent Pinchart , Mauro Carvalho Chehab , linux-media@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] media: uvcvideo: Do not alloc dev->status Message-ID: References: <20221212-uvc-race-v2-0-54496cc3b8ab@chromium.org> <20221212-uvc-race-v2-2-54496cc3b8ab@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221212-uvc-race-v2-2-54496cc3b8ab@chromium.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On (22/12/13 15:35), Ricardo Ribalda wrote: [..] > +++ b/drivers/media/usb/uvc/uvcvideo.h > @@ -559,7 +559,7 @@ struct uvc_device { > /* Status Interrupt Endpoint */ > struct usb_host_endpoint *int_ep; > struct urb *int_urb; > - u8 *status; > + u8 status[UVC_MAX_STATUS_SIZE]; Can we use `struct uvc_control_status status;` instead of open-coding it? Seems that this is what the code wants anyway: struct uvc_control_status *status = (struct uvc_control_status *)dev->status; And then we can drop casts in uvc_status_complete().