Re: [PATCH 5.15.y v2] serial: fixup backport of "serial: Deassert Transmit Enable on probe in driver-specific way"

[Dominique Martinet <dominique.martinet@atmark-techno.com>]

Rasmus Villemoes wrote on Thu, Dec 22, 2022 at 12:44:14PM +0100:
> When 7c7f9bc986e6 ("serial: Deassert Transmit Enable on probe in
> driver-specific way") got backported to 5.15.y, there known as
> b079d3775237, some hunks were accidentally left out.
> 
> In fsl_lpuart.c, this amounts to uart_remove_one_port() being called
> in an error path despite uart_add_one_port() not having been called.
> 
> In serial_core.c, it is possible that the omission in
> uart_suspend_port() is harmless, but the backport did have the
> corresponding hunk in uart_resume_port(), it runs counter to the
> original commit's intention of
> 
>   Skip any invocation of ->set_mctrl() if RS485 is enabled.
> 
> and it's certainly better to be aligned with upstream.
> 
> Fixes: b079d3775237 ("serial: Deassert Transmit Enable on probe in driver-specific way")
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Thank you!
I've confirmed both hunks are part of the original patch; I'm not quite
sure why we missed them...

Reviewed-by: Dominique MARTINET <dominique.martinet@atmark-techno.com>


This doesn't apply cleanly to 5.10 because 5.10 did not get
401fb66a3 ("fsl_lpuart: Don't enable interrupts too early") backported,
I think it makes sense to take as well so I'll send a backport of these
two patches for 5.10

-- 
Dominique