From: Sasha Levin <sashal@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Tyler Hicks <code@tyhicks.com>,
gregkh@linuxfoundation.org, stable@vger.kernel.org,
Shuah Khan <shuah@kernel.org>,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, Gavin Shan <gshan@redhat.com>,
Marc Zyngier <maz@kernel.org>,
Karolina Drobnik <karolinadrobnik@gmail.com>,
Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH 5.15 0/2] Fix kvm selftest build failures in linux-5.15.y
Date: Sat, 24 Dec 2022 22:33:54 -0500 [thread overview]
Message-ID: <Y6fEohBcwosOVKch@sashalap> (raw)
In-Reply-To: <d0519826-79ae-38b4-5ec2-04c7e0874ef6@redhat.com>
On Fri, Dec 23, 2022 at 05:45:44PM +0100, Paolo Bonzini wrote:
>On 12/23/22 01:09, Tyler Hicks wrote:
>>From: "Tyler Hicks" <code@tyhicks.com>
>>
>>The backport of commit 05c2224d4b04 ("KVM: selftests: Fix number of
>>pages for memory slot in memslot_modification_stress_test") broke the
>>build of the KVM selftest memslot_modification_stress_test.c source file
>>in two ways:
>>
>>- Incorrectly assumed that max_t() was defined despite commit
>> 5cf67a6051ea ("tools/include: Add _RET_IP_ and math definitions to
>> kernel.h") not being present
>>- Incorrectly assumed that kvm_vm struct members could be directly
>> accessed despite b530eba14c70 ("KVM: selftests: Get rid of
>> kvm_util_internal.h") not being present
>>
>>Backport the first commit, as it is simple enough. Work around the lack
>>of the second commit by using the accessors to get to the kvm_vm struct
>>members.
>>
>>Note that the linux-6.0.y backport of commit 05c2224d4b04 ("KVM:
>>selftests: Fix number of pages for memory slot in
>>memslot_modification_stress_test") is fine because the two prerequisite
>>commits, mentioned above, are both present in v6.0.
>>
>>Tyler
>>
>>Karolina Drobnik (1):
>> tools/include: Add _RET_IP_ and math definitions to kernel.h
>>
>>Tyler Hicks (Microsoft) (1):
>> KVM: selftests: Fix build regression by using accessor function
>>
>> tools/include/linux/kernel.h | 6 ++++++
>> .../selftests/kvm/memslot_modification_stress_test.c | 2 +-
>> 2 files changed, 7 insertions(+), 1 deletion(-)
>>
>
>Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>
Queued up, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2022-12-25 3:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 0:09 [PATCH 5.15 0/2] Fix kvm selftest build failures in linux-5.15.y Tyler Hicks
2022-12-23 0:09 ` [PATCH 5.15 1/2] tools/include: Add _RET_IP_ and math definitions to kernel.h Tyler Hicks
2022-12-23 0:09 ` [PATCH 5.15 2/2] KVM: selftests: Fix build regression by using accessor function Tyler Hicks
2022-12-23 16:45 ` [PATCH 5.15 0/2] Fix kvm selftest build failures in linux-5.15.y Paolo Bonzini
2022-12-25 3:33 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6fEohBcwosOVKch@sashalap \
--to=sashal@kernel.org \
--cc=code@tyhicks.com \
--cc=gregkh@linuxfoundation.org \
--cc=gshan@redhat.com \
--cc=karolinadrobnik@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).