From: Greg KH <gregkh@linuxfoundation.org>
To: Wang Yugui <wangyugui@e16-tech.com>
Cc: stable@vger.kernel.org
Subject: Re: queue-6.1 drop perf-stat-display-event-stats-using-aggr-counts.patch please
Date: Wed, 28 Dec 2022 15:22:03 +0100 [thread overview]
Message-ID: <Y6xRC6RjHkSHgSQQ@kroah.com> (raw)
In-Reply-To: <20221227172742.10DE.409509F4@e16-tech.com>
On Tue, Dec 27, 2022 at 05:27:43PM +0800, Wang Yugui wrote:
> Hi,
>
> > On Tue, Dec 27, 2022 at 08:25:45AM +0800, Wang Yugui wrote:
> > > Hi,
> > >
> > > drop perf-stat-display-event-stats-using-aggr-counts.patch
> > > from queue-6.1 please.
> > >
> > > It failed to compile on 6.1.y now.
> >
> > Why not just also queue up b89761351089 ("perf stat: Update event skip
> > condition for system-wide per-thread mode and merged uncore and hybrid
> > events")?
>
> We could add
> ca68b374d040 (perf stat: Add struct perf_stat_aggr to perf_stat_evsel)
>
> to queue-6.1 before the patch 'perf-stat-display-event-stats-using-aggr-counts.patch'
>
> to fix the build error.
> util/stat-display.c: In function 'print_counter_aggrdata':
> util/stat-display.c:690:35: error: 'struct perf_stat_evsel' has no member named 'aggr'
> struct perf_stat_aggr *aggr = &ps->aggr[s];
Ok, that got messy fast, as things didn't apply.
I've dropped the original commit here now, can you send a backported
series to us for inclusion in 6.1 that will work properly?
thanks,
greg k-h
prev parent reply other threads:[~2022-12-28 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 0:25 queue-6.1 drop perf-stat-display-event-stats-using-aggr-counts.patch please Wang Yugui
2022-12-27 7:48 ` Greg KH
2022-12-27 9:27 ` Wang Yugui
2022-12-28 14:22 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6xRC6RjHkSHgSQQ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox