From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: Tom Saeger <tom.saeger@oracle.com>,
stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 5.15] cpufreq: governor: Use kobject release() method to free dbs_data
Date: Sun, 22 Jan 2023 14:44:24 +0100 [thread overview]
Message-ID: <Y809uFh7F2s7/GN7@kroah.com> (raw)
In-Reply-To: <Y8tE1fkJN5BvhWym@pek-khao-d2>
On Sat, Jan 21, 2023 at 09:50:13AM +0800, Kevin Hao wrote:
> On Fri, Jan 20, 2023 at 02:40:32PM -0700, Tom Saeger wrote:
> >
> > applies but has build error:
> >
> > /home/tsaeger/workspace/linux/linux-5.15.y/drivers/cpufreq/cpufreq_governor.c: In function ‘cpufreq_dbs_data_release’:
> > /home/tsaeger/workspace/linux/linux-5.15.y/drivers/cpufreq/cpufreq_governor.c:393:49: error: implicit declaration of function ‘to_gov_attr_set’ [-Werror=implicit-function-declaration]
> > 393 | struct dbs_data *dbs_data = to_dbs_data(to_gov_attr_set(kobj));
> > | ^~~~~~~~~~~~~~~
> > /home/tsaeger/workspace/linux/linux-5.15.y/drivers/cpufreq/cpufreq_governor.c:393:49: warning: passing argument 1 of ‘to_dbs_data’ makes pointer from integer without a cast [-Wint-conversion]
> > 393 | struct dbs_data *dbs_data = to_dbs_data(to_gov_attr_set(kobj));
> > | ^~~~~~~~~~~~~~~~~~~~~
> > | |
> > | int
> > In file included from /home/tsaeger/workspace/linux/linux-5.15.y/drivers/cpufreq/cpufreq_governor.c:20:
> > /home/tsaeger/workspace/linux/linux-5.15.y/drivers/cpufreq/cpufreq_governor.h:49:65: note: expected ‘struct gov_attr_set *’ but argument is of type ‘int’
> > 49 | static inline struct dbs_data *to_dbs_data(struct gov_attr_set *attr_set)
> > | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
> > cc1: some warnings being treated as errors
> >
> >
> > 5.15.y first with:
> > ae2650865127 ("cpufreq: Move to_gov_attr_set() to cpufreq.h")
>
> I managed to forget this commit.
Please submit a working patch series that at least attempts to show you
tested this :)
thanks,
greg k-h
next prev parent reply other threads:[~2023-01-22 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 4:26 [PATCH 5.15] cpufreq: governor: Use kobject release() method to free dbs_data Kevin Hao
2023-01-20 6:39 ` Greg Kroah-Hartman
2023-01-20 8:00 ` Kevin Hao
2023-01-20 21:40 ` Tom Saeger
2023-01-21 1:50 ` Kevin Hao
2023-01-22 13:44 ` Greg Kroah-Hartman [this message]
2023-01-22 14:43 ` Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y809uFh7F2s7/GN7@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=haokexin@gmail.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tom.saeger@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox