Re: [PATCH] Revert "ALSA: usb-audio: Drop superfluous interface setup at parsing"

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Jan 14, 2023 at 05:38:19PM +1100, Michael Ralston wrote:
> This reverts commit ac5e2fb425e1121ceef2b9d1b3ffccc195d55707.
> 
> The commit caused a regression on Behringer UMC404HD (and likely
> others).  As the change was meant only as a minor optimization, it's
> better to revert it to address the regression.
> 
> It appears that the original revert patch had spaces instead of tabs so it 
> would not apply. Hopefully this fixes that. Please forgive my ignorance if I 
> have misunderstood.
> 
> Reported-and-tested-by: Michael Ralston <michael@ralston.id.au>
> Cc: <stable@vger.kernel.org>
> Link: https://lore.kernel.org/r/CAC2975JXkS1A5Tj9b02G_sy25ZWN-ys+tc9wmkoS=qPgKCogSg@mail.gmail.com
> Link: https://lore.kernel.org/r/20230104150944.24918-1-tiwai@suse.de
> 
> diff --git a/sound/usb/stream.c b/sound/usb/stream.c
> index f75601ca2d52..f10f4e6d3fb8 100644
> --- a/sound/usb/stream.c
> +++ b/sound/usb/stream.c
> @@ -1222,6 +1222,12 @@ static int __snd_usb_parse_audio_interface(struct 
> snd_usb_audio *chip,

Thanks for the backport, but your email client line-wrapped this line.
I fixed it up by hand, but you might want to fix your client for next
time.

greg k-h