From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE791C3DA78 for ; Tue, 17 Jan 2023 10:15:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235906AbjAQKP6 (ORCPT ); Tue, 17 Jan 2023 05:15:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236294AbjAQKPz (ORCPT ); Tue, 17 Jan 2023 05:15:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B4C23C51 for ; Tue, 17 Jan 2023 02:15:54 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 26BA7B8125C for ; Tue, 17 Jan 2023 10:15:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7565FC433D2; Tue, 17 Jan 2023 10:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673950551; bh=lhx/KUqrh5e3ZOehwPrxoQA/EnH6CB7TxUNOKTl/iE4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PfhP5kBvoHRj9gkK8gF/GM9GVVQS3FHUzc34oTv4oZFNH+xIdhP4eNyJvE7pDAwvS J40kdignJbvzWrtRvrpBP8+ji6xhbgZIaumIC8nQrkz/4Kj3VPzU96MXq7osKZu2kO AJqVgCh1yguL2MY6SfO525B6Jd0+E+pB52UxkNVQ= Date: Tue, 17 Jan 2023 09:40:00 +0100 From: Greg Kroah-Hartman To: Johannes Berg Cc: "stable@vger.kernel.org" , "patches@lists.linux.dev" , Zhengchao Shao , Sasha Levin Subject: Re: [PATCH 4.14 097/338] wifi: mac80211: fix memory leak in ieee80211_if_add() Message-ID: References: <20230116154820.689115727@linuxfoundation.org> <20230116154825.125747074@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 16, 2023 at 06:14:35PM +0100, Johannes Berg wrote: > On Mon, 2023-01-16 at 15:49 +0000, Greg Kroah-Hartman wrote: > > From: Zhengchao Shao > > > > [ Upstream commit 13e5afd3d773c6fc6ca2b89027befaaaa1ea7293 ] > > > > When register_netdevice() failed in ieee80211_if_add(), ndev->tstats > > isn't released. Fix it. > > > > Please drop this wherever you still can - we just reverted it because it > was actually based on broken analysis. Thanks, will drop it from 5.4 and older queues. greg k-h