From: Greg KH <gregkh@linuxfoundation.org>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: stable@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH stable-6.1 1/1] io_uring/msg_ring: fix remote queue to disabled ring
Date: Fri, 27 Jan 2023 08:34:04 +0100 [thread overview]
Message-ID: <Y9N+bBWLWvXbXF9/@kroah.com> (raw)
In-Reply-To: <8f5f017b-ba8c-b47c-3812-f61c4ed4151a@gmail.com>
On Mon, Jan 23, 2023 at 03:29:25PM +0000, Pavel Begunkov wrote:
> On 1/23/23 15:23, Greg KH wrote:
> > On Mon, Jan 23, 2023 at 03:03:24PM +0000, Pavel Begunkov wrote:
> > > [ upstream commit 8579538c89e33ce78be2feb41e07489c8cbf8f31 ]
> > >
> > > IORING_SETUP_R_DISABLED rings don't have the submitter task set, so
> > > it's not always safe to use ->submitter_task. Disallow posting msg_ring
> > > messaged to disabled rings. Also add task NULL check for loosy sync
> > > around testing for IORING_SETUP_R_DISABLED.
> > >
> > > Cc: stable@vger.kernel.org
> > > Fixes: 6d043ee1164ca ("io_uring: do msg_ring in target task via tw")
> >
> > This commit is only in 6.2-rc1, so is it really relevant for this commit
> > to go to 6.1?
> In short, yes.
>
>
> The upstream commit fixes a bug in 6.2, that's the Fixes tag, but
> it also adjusts behaviour of the feature, which came in earlier
> kernels. My bad I didn't split the patch in two.
>
> I also thought Jens added a second Fixes tag but it's not there.
>
> Fixes: 4f57f06ce2186 ("io_uring: add support for IORING_OP_MSG_RING command")
Great, now queued up, thanks!
greg k-h
prev parent reply other threads:[~2023-01-27 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 15:03 [PATCH stable-6.1 1/1] io_uring/msg_ring: fix remote queue to disabled ring Pavel Begunkov
2023-01-23 15:23 ` Greg KH
2023-01-23 15:29 ` Pavel Begunkov
2023-01-27 7:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9N+bBWLWvXbXF9/@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox