From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6529C61DA4 for ; Thu, 2 Feb 2023 17:18:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232532AbjBBRSZ (ORCPT ); Thu, 2 Feb 2023 12:18:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232530AbjBBRSV (ORCPT ); Thu, 2 Feb 2023 12:18:21 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68BDD2B625; Thu, 2 Feb 2023 09:18:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 115A9B8275B; Thu, 2 Feb 2023 17:18:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D285C433EF; Thu, 2 Feb 2023 17:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675358296; bh=8EOYqjD89rhTIJQftQCfFlO/orv5JhWP/InSywBVBlo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vRJBpddAQ7CHarsSyFTSBHW/Io9IZRJlLGuxh29jVpSBr/TSZK3DYHQiavjUr3inL uE0LwXF7HHayQIGgFOjq/OewG1CZ3G9a7SI+pXDdPdsbtXzay5RL1BzspSD0B0w520 ZihxmhVn+ta27UynzQE0OrqfKdz8/6elEUx0BNUVpfv/CORQ4oz3JqBSiomFxf4xAz lOZKYC/uUql7b9aq4ZI21SHsBRuRLSpWc/H65BrOe+3kUK/CsmlmXhiOh1twX3Yvk/ zNkrG6x4SE+rpETQ9K1Pp7qe9Zg7wbTG/AHTNO2Yu6dYOKEIGZL4IRaBJUeMhsAtHv zChotfrDxiTtw== Date: Thu, 2 Feb 2023 12:18:15 -0500 From: Sasha Levin To: Mario Limonciello Cc: "stable-commits@vger.kernel.org" , "stable@vger.kernel.org" , Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski Subject: Re: Patch "gpiolib: acpi: Allow ignoring wake capability on pins that aren't in _AEI" has been added to the 6.1-stable tree Message-ID: References: <20230201164307.1305059-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Feb 01, 2023 at 09:10:01PM -0600, Mario Limonciello wrote: >On 2/1/23 21:06, Sasha Levin wrote: >>On Wed, Feb 01, 2023 at 07:39:29PM +0000, Limonciello, Mario wrote: >>>[Public] >>> >>> >>> >>>>-----Original Message----- >>>>From: Sasha Levin >>>>Sent: Wednesday, February 1, 2023 10:43 >>>>To: stable-commits@vger.kernel.org; Limonciello, Mario >>>> >>>>Cc: Mika Westerberg ; Andy Shevchenko >>>>; Linus Walleij >>>>; Bartosz Golaszewski >>>>Subject: Patch "gpiolib: acpi: Allow ignoring wake capability on >>>>pins that aren't >>>>in _AEI" has been added to the 6.1-stable tree >>>> >>>>This is a note to let you know that I've just added the patch titled >>>> >>>>    gpiolib: acpi: Allow ignoring wake capability on pins that >>>>aren't in _AEI >>>> >>>>to the 6.1-stable tree which can be found at: >>>>    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable- >>>>queue.git;a=summary >>>> >>>>The filename of the patch is: >>>>     gpiolib-acpi-allow-ignoring-wake-capability-on-pins-.patch >>>>and it can be found in the queue-6.1 subdirectory. >>>> >>>>If you, or anyone else, feels it should not be added to the stable tree, >>>>please let know about it. >>> >>>Hi Sasha, >>> >>>I suggest you also pick up two other fixes to go with this one. >>> >>>1) this fix which was in the same series: >>> >>>4cb786180dfb ("gpiolib: acpi: Add a ignore wakeup quirk for Clevo >>>NL5xRU") >> >>This commit has a fixes tag which points to a commit we don't have in >>the 6.1 tree: 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting >>wakeup_capable"), could you confirm? > >Yes; technically it's already problematic in 6.1 but the default >policy doesn't set it for enabled. If a user manually set it to >enabled the problem happens. > >6.2 it happens automatically because policy changed from that commit. > >So I think this one makes sense. > >> >>>2) This fix which is tangentially related (fixes something from >>>the same original >>>series that exposed the regressions). >>> >>>d63f11c02b8d ("gpiolib-acpi: Don't set GPIOs for wakeup in S3 mode") >> >>Same as above. > >This has two fixes tags, one of them is in 6.1. It makes sense to >take back to 6.1, the reporters first noticed it in 6.1. > Queued both, thanks! -- Thanks, Sasha