* [PATCH] usb: roles: disable pm for role switch device
@ 2023-02-03 10:10 Linyu Yuan
2023-02-03 10:18 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Linyu Yuan @ 2023-02-03 10:10 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman
Cc: linux-usb, stable, Jack Pham, Wesley Cheng, Pratham Pratap,
Linyu Yuan
there is no PM operation for a role switch device,
call device_set_pm_not_required() in usb_role_switch_register() to disable.
Cc: stable@vger.kernel.org # 5.4+
Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
---
drivers/usb/roles/class.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
index eacb46e..b303c64 100644
--- a/drivers/usb/roles/class.c
+++ b/drivers/usb/roles/class.c
@@ -344,6 +344,7 @@ usb_role_switch_register(struct device *parent,
dev_set_drvdata(&sw->dev, desc->driver_data);
dev_set_name(&sw->dev, "%s-role-switch",
desc->name ? desc->name : dev_name(parent));
+ device_set_pm_not_required(&sw->dev);
ret = device_register(&sw->dev);
if (ret) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: roles: disable pm for role switch device
2023-02-03 10:10 [PATCH] usb: roles: disable pm for role switch device Linyu Yuan
@ 2023-02-03 10:18 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2023-02-03 10:18 UTC (permalink / raw)
To: Linyu Yuan
Cc: Heikki Krogerus, linux-usb, stable, Jack Pham, Wesley Cheng,
Pratham Pratap
On Fri, Feb 03, 2023 at 06:10:59PM +0800, Linyu Yuan wrote:
> there is no PM operation for a role switch device,
> call device_set_pm_not_required() in usb_role_switch_register() to disable.
>
> Cc: stable@vger.kernel.org # 5.4+
> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
What commit id does this fix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-03 10:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-03 10:10 [PATCH] usb: roles: disable pm for role switch device Linyu Yuan
2023-02-03 10:18 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).