From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Ahmed S. Darwish" <a.darwish@linutronix.de>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Felipe Balbi <balbi@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Peter Chen <peter.chen@nxp.com>, Lee Jones <lee.jones@linaro.org>,
Alan Stern <stern@rowland.harvard.edu>,
Dejin Zheng <zhengdejin5@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Michal Nazarewicz <mina86@mina86.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] usb: udc: core: Use lock when write to soft_connect
Date: Thu, 14 Jan 2021 10:06:45 +0100 [thread overview]
Message-ID: <YAAJpb1myYDviJO7@kroah.com> (raw)
In-Reply-To: <CAHp75Vf3eZjg20QEr6YqdY7R1Eu=D2za+sKb0vVBaAmETg1z4Q@mail.gmail.com>
On Thu, Jan 14, 2021 at 09:03:53AM +0200, Andy Shevchenko wrote:
> On Thursday, January 14, 2021, Ahmed S. Darwish <a.darwish@linutronix.de>
> wrote:
>
> > On Wed, Jan 13, 2021 at 07:38:28PM -0800, Thinh Nguyen wrote:
> > ...
> > > @@ -1543,10 +1546,12 @@ static ssize_t soft_connect_store(struct device
> > *dev,
> > > usb_gadget_udc_stop(udc);
> > > } else {
> > > dev_err(dev, "unsupported command '%s'\n", buf);
> > > - return -EINVAL;
> > > + ret = -EINVAL;
> > > }
> > >
> > > - return n;
>
>
>
> Should be ret = n; here.
Why? That happened higher up in the patch.
thanks,
greg k-h
next prev parent reply other threads:[~2021-01-14 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 3:38 [PATCH v2] usb: udc: core: Use lock when write to soft_connect Thinh Nguyen
2021-01-14 6:41 ` Ahmed S. Darwish
[not found] ` <CAHp75Vf3eZjg20QEr6YqdY7R1Eu=D2za+sKb0vVBaAmETg1z4Q@mail.gmail.com>
2021-01-14 8:00 ` Thinh Nguyen
2021-01-14 9:06 ` Greg Kroah-Hartman [this message]
2021-01-14 8:56 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAAJpb1myYDviJO7@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=a.darwish@linutronix.de \
--cc=andy.shevchenko@gmail.com \
--cc=balbi@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=peter.chen@nxp.com \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox