From: Greg KH <greg@kroah.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
amd-gfx@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH -stable] drm/amdgpu/display: drop DCN support for aarch64
Date: Thu, 21 Jan 2021 13:46:22 +0100 [thread overview]
Message-ID: <YAl3nv41xcTY+Vef@kroah.com> (raw)
In-Reply-To: <20210121092040.110267-1-ardb@kernel.org>
On Thu, Jan 21, 2021 at 10:20:40AM +0100, Ard Biesheuvel wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
>
> commit c241ed2f0ea549c18cff62a3708b43846b84dae3 upstream.
>
> >From Ard:
>
> "Simply disabling -mgeneral-regs-only left and right is risky, given that
> the standard AArch64 ABI permits the use of FP/SIMD registers anywhere,
> and GCC is known to use SIMD registers for spilling, and may invent
> other uses of the FP/SIMD register file that have nothing to do with the
> floating point code in question. Note that putting kernel_neon_begin()
> and kernel_neon_end() around the code that does use FP is not sufficient
> here, the problem is in all the other code that may be emitted with
> references to SIMD registers in it.
>
> So the only way to do this properly is to put all floating point code in
> a separate compilation unit, and only compile that unit with
> -mgeneral-regs-only."
>
> Disable support until the code can be properly refactored to support this
> properly on aarch64.
>
> Acked-by: Will Deacon <will@kernel.org>
> Reported-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> [ardb: backport to v5.10 by reverting c38d444e44badc55 instead]
> Acked-by: Alex Deucher <alexander.deucher@amd.com> # v5.10 backport
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> The original commit does not apply cleanly to v5.10, as it reverts a
> combination of patches, some of which are not present in v5.10.
>
> This patch is a straight revert of c38d444e44badc55, which is the only
> change that needs to be backed out from v5.10, and amounts to the same
> thing as the original mainline commit.
Now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2021-01-21 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 9:20 [PATCH -stable] drm/amdgpu/display: drop DCN support for aarch64 Ard Biesheuvel
2021-01-21 12:46 ` Greg KH [this message]
2021-01-21 16:39 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAl3nv41xcTY+Vef@kroah.com \
--to=greg@kroah.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ardb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox