From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41D22C433DB for ; Sat, 6 Feb 2021 13:20:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1021D64EBE for ; Sat, 6 Feb 2021 13:20:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230127AbhBFNUp (ORCPT ); Sat, 6 Feb 2021 08:20:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:35858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230126AbhBFNUn (ORCPT ); Sat, 6 Feb 2021 08:20:43 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8DA5264EBC; Sat, 6 Feb 2021 13:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612617600; bh=m3attUaLPE9Ru+kOwqRvJP4eo6QUeyvo9aYOsKMlySA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JXQvmaYnAU8P3vwCI/SUUrv9vXtAgV1Bvg6RQRAkazGT1ZW5U48XryjlElF51WDg4 GhKDTfV/MAypDNXBlIBDPsj7NEJQ+hhusLXwutbsGk8sOJMo3WY/ud9CDP6vWe1Y3H m7q31sOCcFza0UeTJvSWeE66FwBy4ITg0CYNu3Jw= Date: Sat, 6 Feb 2021 14:19:57 +0100 From: Greg Kroah-Hartman To: Willy Tarreau Cc: Guenter Roeck , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, stable@vger.kernel.org, lwn@lwn.net, jslaby@suse.cz, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com Subject: Re: Linux 4.4.256 Message-ID: References: <1612534196241236@kroah.com> <20210205205658.GA136925@roeck-us.net> <20210206131113.GB7312@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210206131113.GB7312@1wt.eu> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sat, Feb 06, 2021 at 02:11:13PM +0100, Willy Tarreau wrote: > On Sat, Feb 06, 2021 at 02:00:27PM +0100, Greg Kroah-Hartman wrote: > > I think Sasha's patch here: > > https://lore.kernel.org/r/20210205174702.1904681-1-sashal@kernel.org > > is looking like the solution. > > It might cause trouble to those forcing SUBLEVEL to a given version such > as .0 to avoid exposing the exact stable version. I guess we should > instead try to integrate a test on the value itself and cap it at 255. That's the main goal of the upstream submission that checks the value before capping it: https://lore.kernel.org/r/20210206035033.2036180-2-sashal@kernel.org > Something like this looks more robust to me, it will use SUBLEVEL for > values 0 to 255 and 255 for any larger value: > > - expr $(VERSION) \* 65536 + 0$(PATCHLEVEL) \* 256 + 0$(SUBLEVEL)); \ > + expr $(VERSION) \* 65536 + 0$(PATCHLEVEL) \* 256 + 255 \* (0$(SUBLEVEL) > 255) + 0$(SUBLEVEL) * (0$(SUBLEVEL \<= 255)); \ I think you just rewrote the above linked patch :) thanks, greg k-h