From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
stable@vger.kernel.org, "Russell King" <linux@armlinux.org.uk>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 5.10-stable] gpio: mvebu: fix pwm .get_state period calculation
Date: Wed, 27 Jan 2021 14:19:42 +0100 [thread overview]
Message-ID: <YBFobgWtygnREgU7@kroah.com> (raw)
In-Reply-To: <87im7iy1e8.fsf@tarshish>
On Wed, Jan 27, 2021 at 03:06:55PM +0200, Baruch Siach wrote:
> Hi Uwe,
>
> Thanks for your review.
>
> On Tue, Jan 26 2021, Uwe Kleine-König wrote:
> > On Tue, Jan 26, 2021 at 11:00:11AM +0200, Baruch Siach wrote:
> >> commit e73b0101ae5124bf7cd3fb5d250302ad2f16a416 upstream.
> >>
> >> The period is the sum of on and off values. That is, calculate period as
> >>
> >> ($on + $off) / clkrate
> >>
> >> instead of
> >>
> >> $off / clkrate - $on / clkrate
> >>
> >> that makes no sense.
> >>
> >> Reported-by: Russell King <linux@armlinux.org.uk>
> >> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >> Fixes: 757642f9a584e ("gpio: mvebu: Add limited PWM support")
> >> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > Doesn't this need something like:
> >
> > [baruch: Backported to 5.10]
> >
> > plus a new S-o-B?
>
> I could not find this requirement in the stable-kernel-rules.rst (Option
> 3) text.
>
> Greg, should I resend the patch with another SoB?
Please do!
thanks,
greg k-h
prev parent reply other threads:[~2021-01-27 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 9:00 [PATCH 5.10-stable] gpio: mvebu: fix pwm .get_state period calculation Baruch Siach
2021-01-26 18:06 ` Uwe Kleine-König
2021-01-27 13:06 ` Baruch Siach
2021-01-27 13:19 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBFobgWtygnREgU7@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=baruch@tkos.co.il \
--cc=bgolaszewski@baylibre.com \
--cc=linux@armlinux.org.uk \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox