From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E6FC433E0 for ; Fri, 29 Jan 2021 17:20:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDF4864E04 for ; Fri, 29 Jan 2021 17:20:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232012AbhA2RUt (ORCPT ); Fri, 29 Jan 2021 12:20:49 -0500 Received: from mga01.intel.com ([192.55.52.88]:38394 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231307AbhA2RUA (ORCPT ); Fri, 29 Jan 2021 12:20:00 -0500 IronPort-SDR: KdD2zxNwOCJTCwXAxSCOO11EzwgXybrOscZVgvVU1QwFQUY0E88u1Ip2qG3rHy77lumWy/T1R9 5zFFxlleAaKg== X-IronPort-AV: E=McAfee;i="6000,8403,9879"; a="199302221" X-IronPort-AV: E=Sophos;i="5.79,386,1602572400"; d="scan'208";a="199302221" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 09:18:07 -0800 IronPort-SDR: mthzFK5XSPOmte4IPr1AGUAgelZ2uDIBB508jKsPEgdD/e/XOCZ1Ny7qg1wUoRE8njNH2Ot0hY jkNiIZ5mB0uQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,386,1602572400"; d="scan'208";a="357855934" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga006.jf.intel.com with SMTP; 29 Jan 2021 09:18:04 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 29 Jan 2021 19:18:03 +0200 Date: Fri, 29 Jan 2021 19:18:03 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Imre Deak Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH 3/5] drm/i915: Power up combo PHY lanes for for HDMI as well Message-ID: References: <20210128155948.13678-1-ville.syrjala@linux.intel.com> <20210128155948.13678-3-ville.syrjala@linux.intel.com> <20210129170633.GC183052@ideak-desk.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210129170633.GC183052@ideak-desk.fi.intel.com> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Jan 29, 2021 at 07:06:33PM +0200, Imre Deak wrote: > On Thu, Jan 28, 2021 at 05:59:46PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently we only explicitly power up the combo PHY lanes > > for DP. The spec says we should do it for HDMI as well. > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > > index 88cc6e2fbe91..8fbeb8c24efb 100644 > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > > @@ -4337,6 +4337,8 @@ static void intel_enable_ddi_hdmi(struct intel_atomic_state *state, > > intel_de_write(dev_priv, reg, val); > > } > > > > + intel_ddi_power_up_lanes(encoder, crtc_state); > > + > > Not sure if it matters, but the spec says to apply WA #1143 just before > enabling DDI_BUF_CTL. intel_ddi_power_up_lanes() is a nop for pre-icl, so we still do that. Also not sure what the final fate of that w/a will be since apparently it's not working as intended. That said I was debating with myself what order to put these in, but in the end I chose this order because the w/a is related to the vswing programming, and so wanted to keep it next to the BUF_TRANS programming. > > > > /* In HDMI/DVI mode, the port width, and swing/emphasis values > > * are ignored so nothing special needs to be done besides > > * enabling the port. > > -- > > 2.26.2 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel