From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 102BAC4332B for ; Thu, 4 Feb 2021 16:23:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB53164F10 for ; Thu, 4 Feb 2021 16:23:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237085AbhBDQXW (ORCPT ); Thu, 4 Feb 2021 11:23:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:48814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237166AbhBDPIt (ORCPT ); Thu, 4 Feb 2021 10:08:49 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 49B2264DF2; Thu, 4 Feb 2021 15:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612451284; bh=HgRb0A+F4taLF/5Ufpbd+ggyWRE65lywVZwrrarK7Go=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T8Yb5SRphDXUMgbVb8w/9F9eHO0Fu66LoBeHAAo5wR8O1qgAfLSDjhaSpvseyxAIq KtU2MZm3KoRo6g8YHRPm1T0eJEDQTnYZPW2DJXKyJmAYoWuA+1PKImnrqsrcXB1mpX 0gTmJyCzGVaOxmPOkAHh+Y7B6g+SopjOt6/SpKA8= Date: Thu, 4 Feb 2021 16:08:02 +0100 From: Greg KH To: Catalin Marinas Cc: vincenzo.frascino@arm.com, mark.rutland@arm.com, stable@vger.kernel.org, will@kernel.org Subject: Re: FAILED: patch "[PATCH] arm64: Fix kernel address detection of __is_lm_address()" failed to apply to 5.4-stable tree Message-ID: References: <1612104058247187@kroah.com> <20210203131501.GB10424@gaia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210203131501.GB10424@gaia> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Feb 03, 2021 at 01:15:03PM +0000, Catalin Marinas wrote: > Hi Greg, > > On Sun, Jan 31, 2021 at 03:40:58PM +0100, Greg Kroah-Hartman wrote: > > The patch below does not apply to the 5.4-stable tree. > > If someone wants it applied there, or to any other stable or longterm > > tree, then please email the backport, including the original git commit > > id to . > > > > thanks, > > > > greg k-h > > > > ------------------ original commit in Linus's tree ------------------ > > > > From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001 > > From: Vincenzo Frascino > > Date: Tue, 26 Jan 2021 13:40:56 +0000 > > Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address() > > > > Currently, the __is_lm_address() check just masks out the top 12 bits > > of the address, but if they are 0, it still yields a true result. > > This has as a side effect that virt_addr_valid() returns true even for > > invalid virtual addresses (e.g. 0x0). > > > > Fix the detection checking that it's actually a kernel address starting > > at PAGE_OFFSET. > > > > Fixes: 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()") > > Cc: # 5.4.x > > Cc: Will Deacon > > Suggested-by: Catalin Marinas > > Reviewed-by: Catalin Marinas > > Acked-by: Mark Rutland > > Signed-off-by: Vincenzo Frascino > > Link: https://lore.kernel.org/r/20210126134056.45747-1-vincenzo.frascino@arm.com > > Signed-off-by: Catalin Marinas > > I sent you the 5.4 and 5.10 backports of this patch. There is another > fix in this area which I'll send to Linus tonight. It should apply > cleanly on 5.4 and 5.10. Both now applied. What is the git id of the other fix in Linus's tree? thanks, greg k-h