public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Joerg Vehlow <lkml@jv-coder.de>
Cc: Miroslav Lichvar <mlichvar@redhat.com>,
	stable@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	John Stultz <john.stultz@linaro.org>
Subject: Re: [4.14] Failing selftest timer/adjtick
Date: Thu, 11 Feb 2021 11:45:12 +0100	[thread overview]
Message-ID: <YCUKuNsIvPcaMM1e@kroah.com> (raw)
In-Reply-To: <897e03f9-4062-d34f-0445-ff4f047ccd13@jv-coder.de>

On Thu, Feb 11, 2021 at 11:33:05AM +0100, Joerg Vehlow wrote:
> Hi Miroslav,
> 
> On 2/10/2021 2:19 PM, Miroslav Lichvar wrote:
> > That patch cannot be applied alone. It would break the timekeeping in
> > not so obvious ways as there will be unexpected sources of the NTP
> > tracking error. IIRC, at least the following changes would need to be
> > included with it. There may be others.
> > 
> > c2cda2a5bda9 ("timekeeping/ntp: Don't align NTP frequency adjustments to ticks")
> > aea3706cfc4d ("timekeeping: Remove CONFIG_GENERIC_TIME_VSYSCALL_OLD")
> > d4d1fc61eb38 ("ia64: Update fsyscall gettime to use modern vsyscall_update")
> > 
> > My suggestion for a fix would be to increase the limit in the failing
> > test.
> Thanks, that's what I expected. But I still wonder why the test is failing
> almost 100% of time for me on qemu-arm64 (running on x86). Is this a
> regression in 4.14, that was working at some point or was it never tested on
> arm?

Does it work on a real system?  That's the proper test...

  reply	other threads:[~2021-02-11 10:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 12:43 [4.14] Failing selftest timer/adjtick Joerg Vehlow
2021-02-10 13:00 ` Greg KH
2021-02-10 13:07   ` Joerg Vehlow
2021-02-10 13:19     ` Miroslav Lichvar
2021-02-10 18:59       ` Naresh Kamboju
2021-02-11 10:34         ` Joerg Vehlow
2021-02-11 10:33       ` Joerg Vehlow
2021-02-11 10:45         ` Greg KH [this message]
2021-02-11 10:59         ` Miroslav Lichvar
2021-02-18  7:05           ` Joerg Vehlow
2021-03-01  7:04           ` Joerg Vehlow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCUKuNsIvPcaMM1e@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=lkml@jv-coder.de \
    --cc=mingo@kernel.org \
    --cc=mlichvar@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox