From: Greg KH <gregkh@linuxfoundation.org>
To: Marco Elver <elver@google.com>
Cc: rafael@kernel.org, paulmck@kernel.org, dvyukov@google.com,
glider@google.com, andreyknvl@google.com,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] kcsan, debugfs: Move debugfs file creation out of early init
Date: Wed, 3 Mar 2021 10:57:41 +0100 [thread overview]
Message-ID: <YD9dld26cz0RWHg7@kroah.com> (raw)
In-Reply-To: <20210303093845.2743309-1-elver@google.com>
On Wed, Mar 03, 2021 at 10:38:45AM +0100, Marco Elver wrote:
> Commit 56348560d495 ("debugfs: do not attempt to create a new file
> before the filesystem is initalized") forbids creating new debugfs files
> until debugfs is fully initialized. This breaks KCSAN's debugfs file
> creation, which happened at the end of __init().
How did it "break" it? The files shouldn't have actually been created,
right?
> There is no reason to create the debugfs file during early
> initialization. Therefore, move it into a late_initcall() callback.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: stable <stable@vger.kernel.org>
> Fixes: 56348560d495 ("debugfs: do not attempt to create a new file before the filesystem is initalized")
> Signed-off-by: Marco Elver <elver@google.com>
> ---
> I've marked this for 'stable', since 56348560d495 is also intended for
> stable, and would subsequently break KCSAN in all stable kernels where
> KCSAN is available (since 5.8).
No objection from me, just odd that this actually fixes anything :)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2021-03-03 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 9:38 [PATCH] kcsan, debugfs: Move debugfs file creation out of early init Marco Elver
2021-03-03 9:57 ` Greg KH [this message]
2021-03-03 10:18 ` Marco Elver
2021-03-03 10:23 ` Greg KH
2021-03-03 10:27 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD9dld26cz0RWHg7@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox