From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 267D4C433E0 for ; Wed, 3 Mar 2021 13:50:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E927864EF4 for ; Wed, 3 Mar 2021 13:50:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1447259AbhCCNsc (ORCPT ); Wed, 3 Mar 2021 08:48:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:53904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232777AbhCCMcp (ORCPT ); Wed, 3 Mar 2021 07:32:45 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id BDA1F64EE6; Wed, 3 Mar 2021 09:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614765464; bh=m5ZgB2uhhBpzt73LsJTxuAhJfKD5R+vFHoUx+9V28SE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R69mIedG6TCe/QyLb4VgW3wV+3ODZJzZrp11MBZDlqNhK4Iw35dsx5UJKGqa9xTBJ 5McGaTAS/Kpp7NaG0xPizZq4iWOUbZ4RmTY+y8Yf34WuJ8rNj8UEMpoy8hBjbCfZzm DU2ITVOsJL2Kr3VE3DonCKaa92HMx+Z2GMgCFshQ= Date: Wed, 3 Mar 2021 10:57:41 +0100 From: Greg KH To: Marco Elver Cc: rafael@kernel.org, paulmck@kernel.org, dvyukov@google.com, glider@google.com, andreyknvl@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, stable Subject: Re: [PATCH] kcsan, debugfs: Move debugfs file creation out of early init Message-ID: References: <20210303093845.2743309-1-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210303093845.2743309-1-elver@google.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Mar 03, 2021 at 10:38:45AM +0100, Marco Elver wrote: > Commit 56348560d495 ("debugfs: do not attempt to create a new file > before the filesystem is initalized") forbids creating new debugfs files > until debugfs is fully initialized. This breaks KCSAN's debugfs file > creation, which happened at the end of __init(). How did it "break" it? The files shouldn't have actually been created, right? > There is no reason to create the debugfs file during early > initialization. Therefore, move it into a late_initcall() callback. > > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: stable > Fixes: 56348560d495 ("debugfs: do not attempt to create a new file before the filesystem is initalized") > Signed-off-by: Marco Elver > --- > I've marked this for 'stable', since 56348560d495 is also intended for > stable, and would subsequently break KCSAN in all stable kernels where > KCSAN is available (since 5.8). No objection from me, just odd that this actually fixes anything :) Reviewed-by: Greg Kroah-Hartman