Please apply commit 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") to back to v5.10.y

Please apply commit 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") to back to v5.10.y

[Salvatore Bonaccorso]

Hi

517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS")
was applied to mainline fixing (restoring) behaviour to pre 5.7. As
the commit message describes in effect, WBS was broken for all USB-BT
adapters that do not support alt 6.

Can you consider it to apply it to back to 5.10.y?

Regards,
Salvatore

Re: Please apply commit 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") to back to v5.10.y

[Greg Kroah-Hartman]

On Sun, Feb 21, 2021 at 01:46:10PM +0100, Salvatore Bonaccorso wrote:
> Hi
> 
> 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS")
> was applied to mainline fixing (restoring) behaviour to pre 5.7. As
> the commit message describes in effect, WBS was broken for all USB-BT
> adapters that do not support alt 6.
> 
> Can you consider it to apply it to back to 5.10.y?

I do not see any such git commit id in Linus's tree, are you sure you
picked the right one?

greg k-h

Re: Please apply commit 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") to back to v5.10.y

[Trent Piepho]

On Sun, Feb 21, 2021 at 4:53 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Sun, Feb 21, 2021 at 01:46:10PM +0100, Salvatore Bonaccorso wrote:
> > Hi
> >
> > 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS")
> > was applied to mainline fixing (restoring) behaviour to pre 5.7. As
> > the commit message describes in effect, WBS was broken for all USB-BT
> > adapters that do not support alt 6.
> >
> > Can you consider it to apply it to back to 5.10.y?
>
> I do not see any such git commit id in Linus's tree, are you sure you
> picked the right one?

Full hash is 517b693351a2d04f3af1fc0e506ac7e1346094de.

Looks like it should work as I intended on current 5.10.y, but I
didn't test that kernel.

Re: Please apply commit 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") to back to v5.10.y

[Greg Kroah-Hartman]

On Sun, Feb 21, 2021 at 05:03:34AM -0800, Trent Piepho wrote:
> On Sun, Feb 21, 2021 at 4:53 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Sun, Feb 21, 2021 at 01:46:10PM +0100, Salvatore Bonaccorso wrote:
> > > Hi
> > >
> > > 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS")
> > > was applied to mainline fixing (restoring) behaviour to pre 5.7. As
> > > the commit message describes in effect, WBS was broken for all USB-BT
> > > adapters that do not support alt 6.
> > >
> > > Can you consider it to apply it to back to 5.10.y?
> >
> > I do not see any such git commit id in Linus's tree, are you sure you
> > picked the right one?
> 
> Full hash is 517b693351a2d04f3af1fc0e506ac7e1346094de.
> 
> Looks like it should work as I intended on current 5.10.y, but I
> didn't test that kernel.

Ah, this thing isn't even in 5.11, it just now showed up in Linus's
tree.

Give it time to hit at least a released version (i.e. 5.12-rc1) before
we pull it into a stable release.  Unless the bluetooth maintainers say
it is ok to do so earlier than that.

thanks,

greg k-h

Re: Please apply commit 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") to back to v5.10.y

[Salvatore Bonaccorso]

Hi Greg,

On Sun, Feb 21, 2021 at 02:12:17PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Feb 21, 2021 at 05:03:34AM -0800, Trent Piepho wrote:
> > On Sun, Feb 21, 2021 at 4:53 AM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > > On Sun, Feb 21, 2021 at 01:46:10PM +0100, Salvatore Bonaccorso wrote:
> > > > Hi
> > > >
> > > > 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS")
> > > > was applied to mainline fixing (restoring) behaviour to pre 5.7. As
> > > > the commit message describes in effect, WBS was broken for all USB-BT
> > > > adapters that do not support alt 6.
> > > >
> > > > Can you consider it to apply it to back to 5.10.y?
> > >
> > > I do not see any such git commit id in Linus's tree, are you sure you
> > > picked the right one?
> > 
> > Full hash is 517b693351a2d04f3af1fc0e506ac7e1346094de.
> > 
> > Looks like it should work as I intended on current 5.10.y, but I
> > didn't test that kernel.
> 
> Ah, this thing isn't even in 5.11, it just now showed up in Linus's
> tree.
> 
> Give it time to hit at least a released version (i.e. 5.12-rc1) before
> we pull it into a stable release.  Unless the bluetooth maintainers say
> it is ok to do so earlier than that.

Sure. We got a request in Debian to include the commit for an upcoming
5.10.y based update and just want to make sure we do not diverge here
from upstream.  But it's obviously good to wait then unless bluetooth
maintainers give the ack earlier.

Thanks for the quick responses.

Regards,
Salvatore

Re: Please apply commit 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") to back to v5.10.y

[Sjoerd Simons]

On Sun, Feb 21, 2021 at 05:03:34AM -0800, Trent Piepho wrote:
> On Sun, Feb 21, 2021 at 4:53 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Sun, Feb 21, 2021 at 01:46:10PM +0100, Salvatore Bonaccorso wrote:
> > > Hi
> > >
> > > 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS")
> > > was applied to mainline fixing (restoring) behaviour to pre 5.7. As
> > > the commit message describes in effect, WBS was broken for all USB-BT
> > > adapters that do not support alt 6.
> > >
> > > Can you consider it to apply it to back to 5.10.y?
> >
> > I do not see any such git commit id in Linus's tree, are you sure you
> > picked the right one?
> 
> Full hash is 517b693351a2d04f3af1fc0e506ac7e1346094de.
> 
> Looks like it should work as I intended on current 5.10.y, but I
> didn't test that kernel.

I've been using it for a while now on top of 5.10.y; It fixes issues for me with
both Intel and Broadcom based usb adapters. Fwiw i previously[0] suggested
adding fixes/tested-by tags but those didn't make it into the merged version.

Regards,
  Sjoerd

0: https://lore.kernel.org/lkml/YB68RUVLRGQKS+yH@dawn.lan/

Re: Please apply commit 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS") to back to v5.10.y

[Greg Kroah-Hartman]

On Sun, Feb 21, 2021 at 02:17:41PM +0100, Salvatore Bonaccorso wrote:
> Hi Greg,
> 
> On Sun, Feb 21, 2021 at 02:12:17PM +0100, Greg Kroah-Hartman wrote:
> > On Sun, Feb 21, 2021 at 05:03:34AM -0800, Trent Piepho wrote:
> > > On Sun, Feb 21, 2021 at 4:53 AM Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > > On Sun, Feb 21, 2021 at 01:46:10PM +0100, Salvatore Bonaccorso wrote:
> > > > > Hi
> > > > >
> > > > > 517b693351a2 ("Bluetooth: btusb: Always fallback to alt 1 for WBS")
> > > > > was applied to mainline fixing (restoring) behaviour to pre 5.7. As
> > > > > the commit message describes in effect, WBS was broken for all USB-BT
> > > > > adapters that do not support alt 6.
> > > > >
> > > > > Can you consider it to apply it to back to 5.10.y?
> > > >
> > > > I do not see any such git commit id in Linus's tree, are you sure you
> > > > picked the right one?
> > > 
> > > Full hash is 517b693351a2d04f3af1fc0e506ac7e1346094de.
> > > 
> > > Looks like it should work as I intended on current 5.10.y, but I
> > > didn't test that kernel.
> > 
> > Ah, this thing isn't even in 5.11, it just now showed up in Linus's
> > tree.
> > 
> > Give it time to hit at least a released version (i.e. 5.12-rc1) before
> > we pull it into a stable release.  Unless the bluetooth maintainers say
> > it is ok to do so earlier than that.
> 
> Sure. We got a request in Debian to include the commit for an upcoming
> 5.10.y based update and just want to make sure we do not diverge here
> from upstream.  But it's obviously good to wait then unless bluetooth
> maintainers give the ack earlier.

This seems sane, I'll queue it up now, thanks.

greg k-h