From: Greg KH <gregkh@linuxfoundation.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Zheng Yejian <zhengyejian1@huawei.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
judy.chenhui@huawei.com, zhangjinhao2@huawei.com,
tglx@linutronix.de
Subject: Re: [PATCH 4.9.257 1/1] futex: Fix OWNER_DEAD fixup
Date: Mon, 22 Feb 2021 13:07:15 +0100 [thread overview]
Message-ID: <YDOec1kosGKKO80g@kroah.com> (raw)
In-Reply-To: <20210222115424.GF376568@dell>
On Mon, Feb 22, 2021 at 11:54:24AM +0000, Lee Jones wrote:
> On Mon, 22 Feb 2021, Zheng Yejian wrote:
>
> > From: Peter Zijlstra <peterz@infradead.org>
> >
> > commit a97cb0e7b3f4c6297fd857055ae8e895f402f501 upstream.
> >
> > Both Geert and DaveJ reported that the recent futex commit:
> >
> > c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex")
> >
> > introduced a problem with setting OWNER_DEAD. We set the bit on an
> > uninitialized variable and then entirely optimize it away as a
> > dead-store.
> >
> > Move the setting of the bit to where it is more useful.
> >
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Reported-by: Dave Jones <davej@codemonkey.org.uk>
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Paul E. McKenney <paulmck@us.ibm.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Fixes: c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex")
> > Link: http://lkml.kernel.org/r/20180122103947.GD2228@hirez.programming.kicks-ass.net
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
> > ---
> > kernel/futex.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
>
> Reviewed-by: Lee Jones <lee.jones@linaro.org>
This does not apply to the 4.9.y tree at all right now, are you all sure
you got the backport correct?
confused,
greg k-h
next prev parent reply other threads:[~2021-02-22 12:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 11:05 [PATCH 4.9.257 0/1] Bugfix for 781691c797de ("futex: Avoid violating the 10th rule of futex") Zheng Yejian
2021-02-22 11:05 ` [PATCH 4.9.257 1/1] futex: Fix OWNER_DEAD fixup Zheng Yejian
2021-02-22 11:54 ` Lee Jones
2021-02-22 12:07 ` Greg KH [this message]
2021-02-22 12:20 ` Zhengyejian (Zetta)
2021-02-22 12:36 ` Greg KH
2021-02-22 13:11 ` Zhengyejian (Zetta)
2021-02-23 13:00 ` Greg KH
2021-02-23 14:51 ` Zhengyejian (Zetta)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDOec1kosGKKO80g@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=judy.chenhui@huawei.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zhangjinhao2@huawei.com \
--cc=zhengyejian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox