From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5975CC433E0 for ; Mon, 22 Feb 2021 12:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 153E964EF1 for ; Mon, 22 Feb 2021 12:37:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbhBVMhK (ORCPT ); Mon, 22 Feb 2021 07:37:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:52048 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230430AbhBVMgy (ORCPT ); Mon, 22 Feb 2021 07:36:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 10AE664DF0; Mon, 22 Feb 2021 12:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613997371; bh=M7OC0qLQpaFewisicVxIydBVJ8+EBYtvL028QSe6Q1Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oVy8ZKKOlDw629IxrXaxDlvWIVkvoAjxGamoHvs92XxV3xKmU09HFyCt3Cp+zhQrw Nd60hJqBCgaotykuEnoQLCrDJynzvjR3KV4iHNlj1/QbfeZO7n6i1Q5X+2e88rUTyl jnWaoW7Ymdrx9FdZxBPY9Tl9HpjL0ND+yesUt3ZM= Date: Mon, 22 Feb 2021 13:36:09 +0100 From: Greg KH To: "Zhengyejian (Zetta)" Cc: Lee Jones , stable@vger.kernel.org, linux-kernel@vger.kernel.org, judy.chenhui@huawei.com, zhangjinhao2@huawei.com, tglx@linutronix.de Subject: Re: [PATCH 4.9.257 1/1] futex: Fix OWNER_DEAD fixup Message-ID: References: <20210222110542.3531596-1-zhengyejian1@huawei.com> <20210222110542.3531596-2-zhengyejian1@huawei.com> <20210222115424.GF376568@dell> <4f06340a-e027-f944-3248-2939639d5e07@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f06340a-e027-f944-3248-2939639d5e07@huawei.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Feb 22, 2021 at 08:20:38PM +0800, Zhengyejian (Zetta) wrote: > > > On 2021/2/22 20:07, Greg KH wrote: > > On Mon, Feb 22, 2021 at 11:54:24AM +0000, Lee Jones wrote: > > > On Mon, 22 Feb 2021, Zheng Yejian wrote: > > > > > > > From: Peter Zijlstra > > > > > > > > commit a97cb0e7b3f4c6297fd857055ae8e895f402f501 upstream. > > > > > > > > Both Geert and DaveJ reported that the recent futex commit: > > > > > > > > c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex") > > > > > > > > introduced a problem with setting OWNER_DEAD. We set the bit on an > > > > uninitialized variable and then entirely optimize it away as a > > > > dead-store. > > > > > > > > Move the setting of the bit to where it is more useful. > > > > > > > > Reported-by: Geert Uytterhoeven > > > > Reported-by: Dave Jones > > > > Signed-off-by: Peter Zijlstra (Intel) > > > > Cc: Andrew Morton > > > > Cc: Linus Torvalds > > > > Cc: Paul E. McKenney > > > > Cc: Peter Zijlstra > > > > Cc: Thomas Gleixner > > > > Fixes: c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex") > > > > Link: http://lkml.kernel.org/r/20180122103947.GD2228@hirez.programming.kicks-ass.net > > > > Signed-off-by: Ingo Molnar > > > > Signed-off-by: Zheng Yejian > > > > --- > > > > kernel/futex.c | 7 +++---- > > > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > > > Reviewed-by: Lee Jones > > > > This does not apply to the 4.9.y tree at all right now, are you all sure > > you got the backport correct? > > > > confused, > > > > greg k-h > > . > > > I make the patch basing on 282aeb477a10 ("Linux 4.9.257"). > Should I base on f0cf73f13b39 ("Linux 4.9.258-rc1")? Yes please as I think this is already there. How about just waiting for the next release to come out, I will push out the 4.4 and 4.9 -rc releases right now as well to give everyone a chance to sync up properly. thanks, greg k-h