From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C52F9C433DB for ; Mon, 1 Mar 2021 14:16:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9436A64E07 for ; Mon, 1 Mar 2021 14:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236290AbhCAOQK (ORCPT ); Mon, 1 Mar 2021 09:16:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:51110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236217AbhCAOQJ (ORCPT ); Mon, 1 Mar 2021 09:16:09 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6DC1D64D99; Mon, 1 Mar 2021 14:15:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614608129; bh=9mINMwSlE6Lx+Ht6ULSem8ouBs47qezztpHF+PAhhSw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RCX7w0rroZjBI8wWRNDjIQ6u97soKDKpqx2MH4Ow+ELjyIAvn7gdp7gLdYXPCAoxb 4dAU3od2y7UJwkyNEZRCHM0A5nL6iRyL/XoasmSWGzPoaIZ8phj3c///f6um+Y9WkW QW0o+YDkedxfj5hNqUO+q0y7Og2NNIhhRVZiQzkg= Date: Mon, 1 Mar 2021 15:15:26 +0100 From: Greg KH To: Zheng Yejian Cc: lee.jones@linaro.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, cj.chengjian@huawei.com, judy.chenhui@huawei.com, zhangjinhao2@huawei.com Subject: Re: [PATCH 4.9.y 1/1] futex: Fix OWNER_DEAD fixup Message-ID: References: <20210223144151.916675-1-zhengyejian1@huawei.com> <20210223144151.916675-2-zhengyejian1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210223144151.916675-2-zhengyejian1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Feb 23, 2021 at 10:41:51PM +0800, Zheng Yejian wrote: > From: Peter Zijlstra > > commit a97cb0e7b3f4c6297fd857055ae8e895f402f501 upstream. > > Both Geert and DaveJ reported that the recent futex commit: > > c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex") > > introduced a problem with setting OWNER_DEAD. We set the bit on an > uninitialized variable and then entirely optimize it away as a > dead-store. > > Move the setting of the bit to where it is more useful. > > Reported-by: Geert Uytterhoeven > Reported-by: Dave Jones > Signed-off-by: Peter Zijlstra (Intel) > Cc: Andrew Morton > Cc: Linus Torvalds > Cc: Paul E. McKenney > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Fixes: c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex") > Link: http://lkml.kernel.org/r/20180122103947.GD2228@hirez.programming.kicks-ass.net > Signed-off-by: Ingo Molnar > Signed-off-by: Zheng Yejian > --- > kernel/futex.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Now queued up, thanks. greg k-h