From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6124C433DB for ; Thu, 4 Mar 2021 13:30:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7344664F43 for ; Thu, 4 Mar 2021 13:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233535AbhCDNa1 (ORCPT ); Thu, 4 Mar 2021 08:30:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:47924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237735AbhCDNaM (ORCPT ); Thu, 4 Mar 2021 08:30:12 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0E7E964F21; Thu, 4 Mar 2021 13:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614864572; bh=P4YAVMP/bhPsLafEg8kyQD4NRQUKl82+bVRnFf+X36Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CosuPNh1D++y+aG9VpuNiB9APYL0JbMxwYXUO5s7bsayyH2jXtEZZ7JtS+OHCXwud 8z8q35PXXaolgttWpQj9HGMYW5fsmingnzbnRbqWA4v2Vrai1IDwixclWnxYjcO9HS 3q/qk3yDvuKRLzuQvwuAg9kApYeg1rIWysS0vmXE= Date: Thu, 4 Mar 2021 14:29:30 +0100 From: Greg KH To: Nobuhiro Iwamatsu Cc: stable@vger.kernel.org, sashal@kernel.org, Emmanuel Grumbach , Luca Coelho , Kalle Valo Subject: Re: [PATCH for 4.4.y] iwlwifi: pcie: fix to correct null check Message-ID: References: <20210303075731.920687-1-nobuhiro1.iwamatsu@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210303075731.920687-1-nobuhiro1.iwamatsu@toshiba.co.jp> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Mar 03, 2021 at 04:57:31PM +0900, Nobuhiro Iwamatsu wrote: > The fixes made in commit: 4ae5798004d8 ("iwlwifi: pcie: add a NULL check in > iwl_pcie_txq_unmap") is not enough in 4.4.y tree.. This still have problems > with null references. This provides the correct fix. > Also, this is a problem only in 4.4.y. This patch has been applied to other > LTS trees, but with the correct fixes. > > Fixes: 4ae5798004d8 ("iwlwifi: pcie: add a NULL check in iwl_pcie_txq_unmap") > Cc: stable@vger.kernel.org > Cc: Emmanuel Grumbach > Cc: Luca Coelho > Cc: Kalle Valo > Cc: Sasha Levin > Signed-off-by: Nobuhiro Iwamatsu (CIP) > --- > drivers/net/wireless/iwlwifi/pcie/tx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Thanks for the fix, now queued up. greg k-h