From: Greg KH <greg@kroah.com>
To: Nikolai Kostrigin <nickel@basealt.ru>
Cc: stable@vger.kernel.org, jingle <jingle.wu@emc.com.tw>,
kernel@pengutronix.de, linux-input@vger.kernel.org,
"'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: elan_i2c: failed to read report data: -71
Date: Thu, 4 Mar 2021 14:38:52 +0100 [thread overview]
Message-ID: <YEDi7H9uIxk6Gb4x@kroah.com> (raw)
In-Reply-To: <15cb57ba-9188-51a1-b931-da45932e199f@basealt.ru>
On Thu, Mar 04, 2021 at 11:49:59AM +0300, Nikolai Kostrigin wrote:
> Hi,
>
> 04.03.2021 09:59, Uwe Kleine-König пишет:
> > Hello,
> >
> > On Wed, Mar 03, 2021 at 05:53:37PM -0800, 'Dmitry Torokhov' wrote:
> >> On Wed, Mar 03, 2021 at 09:03:30PM +0100, Uwe Kleine-König wrote:
> >>> On Wed, Mar 03, 2021 at 07:32:23PM +0100, Uwe Kleine-König wrote:
> >>>> On Wed, Mar 03, 2021 at 11:13:21AM +0800, jingle wrote:
> >>>>> Please updates this patchs.
> >>>>>
> >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/commit/?h=next&id=056115daede8d01f71732bc7d778fb85acee8eb6
> >>>>>
> >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/commit/?h=next&id=e4c9062717feda88900b566463228d1c4910af6d
> >>>>
> >>>> The first was one of the two patches I already tried, but the latter
> >>>> indeed fixes my problem \o/.
> >>>>
> >>>> @Dmitry: If you don't consider your tree stable, feel free to add a
> >>>>
> >>>> Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >>>>
> >>>> to e4c9062717feda88900b566463228d1c4910af6d.
> >>>
> >>> Do you consider this patch for stable? I'd like to see it in Debian's
> >>> 5.10 kernel and I guess I'm not the only one who would benefit from such
> >>> a backport.
> >>
> >> When I was applying the patches I did not realize that there was already
> >> hardware in the wild that needed it. The patches are now in mainline, so
> >> I can no longer adjust the tags, but I will not object if you propose
> >> them for stable.
> >
> > I want to propose to backport commit
> >
> > e4c9062717fe ("Input: elantech - fix protocol errors for some trackpoints in SMBus mode")
> >
> > to the active stable kernels. This commit repairs the track point and
> > the touch pad buttons on a Lenovo Thinkpad E15 here. Without this change
> > I don't get any events apart from an error message for each button press
> > or move of the track point in the kernel log. (Also the error message is
> > the same for all buttons and the track point, so I cannot create a new
> > input event driver in userspace that emulates the right event depending
> > on the error message :-)
> >
> > At least to 5.10.x it applies cleanly, I didn't try the older stable
> > branches.
> >
> > Best regards and thanks
> > Uwe
> >
>
> I'd like to propose to backport [1] also as it was checked along with
> previously proposed patch and fixes Elan Trackpoint operation on
> Thinkpad L13.
>
> Both patches apply cleanly to 5.10.17 in my case.
>
> I also tried to apply to 5.4.x, but failed.
>
> [1] 056115daede8 Input: elan_i2c - add new trackpoint report type 0x5F
Applied to 5.10.y now, thanks.
greg k-h
next prev parent reply other threads:[~2021-03-04 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210302210934.iro3a6chigx72r4n@pengutronix.de>
[not found] ` <016d01d70fdb$2aa48b00$7feda100$@emc.com.tw>
[not found] ` <20210303183223.rtqi63hdl3a7hahv@pengutronix.de>
2021-03-03 20:03 ` elan_i2c: failed to read report data: -71 Uwe Kleine-König
2021-03-04 1:53 ` 'Dmitry Torokhov'
2021-03-04 6:59 ` Uwe Kleine-König
2021-03-04 8:49 ` Nikolai Kostrigin
2021-03-04 13:38 ` Greg KH [this message]
2021-03-05 19:18 ` Uwe Kleine-König
2021-03-11 11:29 ` Nikolai Kostrigin
2021-03-04 13:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEDi7H9uIxk6Gb4x@kroah.com \
--to=greg@kroah.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jingle.wu@emc.com.tw \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=nickel@basealt.ru \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox