From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C62DC433E0 for ; Thu, 4 Mar 2021 13:53:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C8F864F51 for ; Thu, 4 Mar 2021 13:53:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241636AbhCDNwv (ORCPT ); Thu, 4 Mar 2021 08:52:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:56180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241635AbhCDNwZ (ORCPT ); Thu, 4 Mar 2021 08:52:25 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6DE4A64E5F; Thu, 4 Mar 2021 13:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614865905; bh=8KP7mUXHOdCEbP0sYZbziXYJAfr6N6ujWE/9ZROFZq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N+mP+AWQUxD1iNdFOgNGyFLnY+jsxYaFCfEiI2DUnh7mk2PVlK/xE5psnHg5z9jNQ JGp1/ON2cwEkAgWFOEqnWUpvF2F5aAxLgwIHAaz3Ml27SQtSagB4p+bn+e9DYFp+It zhU0SNhIZn3Zlr8s6izvx0N7ZUf02EDk8SsiZWug= Date: Thu, 4 Mar 2021 14:51:42 +0100 From: Greg KH To: Nathan Chancellor Cc: anders.roxell@linaro.org, natechancellor@gmail.com, tsbogend@alpha.franken.de, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] MIPS: VDSO: Use CLANG_FLAGS instead of filtering out" failed to apply to 5.4-stable tree Message-ID: References: <1614592687119110@kroah.com> <20210301162116.hx5vjaeldfvgtieq@24bbad8f3778> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301162116.hx5vjaeldfvgtieq@24bbad8f3778> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Mar 01, 2021 at 09:21:16AM -0700, Nathan Chancellor wrote: > On Mon, Mar 01, 2021 at 10:58:07AM +0100, gregkh@linuxfoundation.org wrote: > > > > The patch below does not apply to the 5.4-stable tree. > > If someone wants it applied there, or to any other stable or longterm > > tree, then please email the backport, including the original git commit > > id to . > > > > thanks, > > > > greg k-h > > > > ------------------ original commit in Linus's tree ------------------ > > > > From 76d7fff22be3e4185ee5f9da2eecbd8188e76b2c Mon Sep 17 00:00:00 2001 > > From: Nathan Chancellor > > Date: Fri, 15 Jan 2021 12:26:22 -0700 > > Subject: [PATCH] MIPS: VDSO: Use CLANG_FLAGS instead of filtering out > > '--target=' > > > > Commit ee67855ecd9d ("MIPS: vdso: Allow clang's --target flag in VDSO > > cflags") allowed the '--target=' flag from the main Makefile to filter > > through to the vDSO. However, it did not bring any of the other clang > > specific flags for controlling the integrated assembler and the GNU > > tools locations (--prefix=, --gcc-toolchain=, and -no-integrated-as). > > Without these, we will get a warning (visible with tinyconfig): > > > > arch/mips/vdso/elf.S:14:1: warning: DWARF2 only supports one section per > > compilation unit > > .pushsection .note.Linux, "a",@note ; .balign 4 ; .long 2f - 1f ; .long > > 4484f - 3f ; .long 0 ; 1:.asciz "Linux" ; 2:.balign 4 ; 3: > > ^ > > arch/mips/vdso/elf.S:34:2: warning: DWARF2 only supports one section per > > compilation unit > > .section .mips_abiflags, "a" > > ^ > > > > All of these flags are bundled up under CLANG_FLAGS in the main Makefile > > and exported so that they can be added to Makefiles that set their own > > CFLAGS. Use this value instead of filtering out '--target=' so there is > > no warning and all of the tools are properly used. > > > > Cc: stable@vger.kernel.org > > Fixes: ee67855ecd9d ("MIPS: vdso: Allow clang's --target flag in VDSO cflags") > > Link: https://github.com/ClangBuiltLinux/linux/issues/1256 > > Reported-by: Anders Roxell > > Signed-off-by: Nathan Chancellor > > Tested-by: Anders Roxell > > Signed-off-by: Thomas Bogendoerfer > > > > diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile > > index 5810cc12bc1d..2131d3fd7333 100644 > > --- a/arch/mips/vdso/Makefile > > +++ b/arch/mips/vdso/Makefile > > @@ -16,16 +16,13 @@ ccflags-vdso := \ > > $(filter -march=%,$(KBUILD_CFLAGS)) \ > > $(filter -m%-float,$(KBUILD_CFLAGS)) \ > > $(filter -mno-loongson-%,$(KBUILD_CFLAGS)) \ > > + $(CLANG_FLAGS) \ > > -D__VDSO__ > > > > ifndef CONFIG_64BIT > > ccflags-vdso += -DBUILD_VDSO32 > > endif > > > > -ifdef CONFIG_CC_IS_CLANG > > -ccflags-vdso += $(filter --target=%,$(KBUILD_CFLAGS)) > > -endif > > - > > # > > # The -fno-jump-tables flag only prevents the compiler from generating > > # jump tables but does not prevent the compiler from emitting absolute > > > > Attached are the 4.19 and 5.4 backports. Both now queued up, thanks. greg k-h