From: Greg KH <greg@kroah.com>
To: Shaoying Xu <shaoyi@amazon.com>
Cc: stable@vger.kernel.org, fllinden@amazon.com
Subject: Re: [PATCH 5.4] arm64 module: set plt* section addresses to 0x0
Date: Thu, 4 Mar 2021 14:48:17 +0100 [thread overview]
Message-ID: <YEDlIRilWxQCSTBF@kroah.com> (raw)
In-Reply-To: <20210301212346.GA1021@amazon.com>
On Mon, Mar 01, 2021 at 09:23:46PM +0000, Shaoying Xu wrote:
> commit f5c6d0fcf90ce07ee0d686d465b19b247ebd5ed7 upstream.
>
> These plt* and .text.ftrace_trampoline sections specified for arm64 have
> non-zero addressses. Non-zero section addresses in a relocatable ELF would
> confuse GDB when it tries to compute the section offsets and it ends up
> printing wrong symbol addresses. Therefore, set them to zero, which mirrors
> the change in commit 5d8591bc0fba ("module: set ksymtab/kcrctab* section
> addresses to 0x0").
>
> Reported-by: Frank van der Linden <fllinden@amazon.com>
> Signed-off-by: Shaoying Xu <shaoyi@amazon.com>
> Cc: <stable@vger.kernel.org>
> Link: https://lore.kernel.org/r/20210216183234.GA23876@amazon.com
> Signed-off-by: Will Deacon <will@kernel.org>
> [shaoyi@amazon.com: made same changes in arch/arm64/kernel/module.lds for 5.4]
> Signed-off-by: Shaoying Xu <shaoyi@amazon.com>
> ---
> arch/arm64/include/asm/module.lds.h was renamed from arch/arm64/kernel/module.lds
> by commit 596b0474d3d9 ("kbuild: preprocess module linker script") since v5.10.
> Therefore, made same changes in arch/arm64/kernel/module.lds for 5.4.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2021-03-04 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 21:23 [PATCH 5.4] arm64 module: set plt* section addresses to 0x0 Shaoying Xu
2021-03-04 13:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEDlIRilWxQCSTBF@kroah.com \
--to=greg@kroah.com \
--cc=fllinden@amazon.com \
--cc=shaoyi@amazon.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox