From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B81C433E0 for ; Thu, 4 Mar 2021 17:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 647EE64F5E for ; Thu, 4 Mar 2021 17:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238515AbhCDRAE (ORCPT ); Thu, 4 Mar 2021 12:00:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:60882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236865AbhCDQ7c (ORCPT ); Thu, 4 Mar 2021 11:59:32 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9743664F59; Thu, 4 Mar 2021 16:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614877132; bh=ogPCAqUrJsPTWID/+dxg64jg17NrKa1OqVqf+iKrOZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NTZ3MuTBdv2veyQJULk1auCEomEWtDBdbyrLSq0BDydjsVqcw1S5s+cUazQWv2KOF mvdM+ix6BlFX6MGTXuAtyLWIQdwB6iog+zJeKWIY8ssps30imD+UnKwNIRqL27k+8V xoczlHPXSUEmp3BpnZu2FKYuD3aUjNtwiNZRf1Ro= Date: Thu, 4 Mar 2021 17:58:49 +0100 From: Greg Kroah-Hartman To: Anthony Iliopoulos Cc: Jens Axboe , Andrew Morton , Matthew Wilcox , stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH STABLE 5.10 5.11] swap: fix swapfile page to sector mapping Message-ID: References: <20210304150824.29878-1-ailiop@suse.com> <20210304150824.29878-5-ailiop@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Mar 04, 2021 at 05:30:00PM +0100, Anthony Iliopoulos wrote: > On Thu, Mar 04, 2021 at 04:16:26PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 04, 2021 at 04:08:24PM +0100, Anthony Iliopoulos wrote: > > > commit caf6912f3f4af7232340d500a4a2008f81b93f14 upstream. > > > > No, this does not look like that commit. > > > > Why can I not just take caf6912f3f4a ("swap: fix swapfile read/write > > offset") directly for 5.10 and 5.11? WHat has changed to prevent that? > > You're right of course, the upstream fix applies even on v5.4 so you > could just take it directly for those branches if this is preferable. But, that commit says it fixes 48d15436fde6 ("mm: remove get_swap_bio"), which is NOT what you are saying here in these patches. So which is it? Is there a problem in 5.11 and older kernels (48d15436fde6 ("mm: remove get_swap_bio") showed up in 5.12-rc1), that requires this fix, or is there nothing needed to be backported? As a note, I've been running swapfiles on 5.11 and earlier just fine for a very long time now, so is this really an issue? confused, greg k-h