From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0806C433E6 for ; Wed, 10 Mar 2021 12:06:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91C0564FC4 for ; Wed, 10 Mar 2021 12:06:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230122AbhCJMFy (ORCPT ); Wed, 10 Mar 2021 07:05:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:60076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232902AbhCJMFd (ORCPT ); Wed, 10 Mar 2021 07:05:33 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7CA2564FEE; Wed, 10 Mar 2021 12:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615377933; bh=l5vVhlzi47+ndhKnHdbL6alj5M0iTeVIjMlxASM81Ew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jNUTo4okGu3XCRwL7mE3LFJ2vSWD6blfMMHhHEymssa+3iYkJwmichJD9+DfP7l3o ZzxJw0UlCoX7xx+bESotwSD5q5tmEQPKhLzlnEPtUy4iovJees/sOZK9eCiohJrYBe TvKzZFleJlysrVvMqiavme3TjqT/3WgeDpRlsKKk= Date: Wed, 10 Mar 2021 13:05:30 +0100 From: Greg Kroah-Hartman To: Hans Verkuil Cc: stable , Jernej =?utf-8?Q?=C5=A0krabec?= , Nicolas Dufresne , Mauro Carvalho Chehab Subject: Re: [PATCH FOR stable v5.11] media: cedrus: Remove checking for required controls Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Mar 10, 2021 at 11:49:38AM +0100, Hans Verkuil wrote: > From: Jernej Skrabec > > [ Upstream commit 7072db89572135f28cad65f15877bf7e67cf2ff8 ] > > According to v4l2 request api specifications, it's allowed to skip > control if its content isn't changed for performance reasons. Cedrus > driver predates that, so it has implemented mechanism to check if all > required controls are included in one request. > > Conform to specifications with removing that mechanism. > > Note that this mechanism with static required flag isn't very good > anyway because need for control is usually signaled in other controls. > > Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") > Cc: stable@vger.kernel.org > Signed-off-by: Jernej Skrabec > Signed-off-by: Hans Verkuil > --- > Without this patch the H264 cedrus support is non-compliant, and since 5.11 > was the first kernel with a stable H264 stateless codec ABI it would be > good to have this merged for 5.11 so the cedrus driver can be used with > H264. Now queued up, thanks. greg k-h