From: Greg KH <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Joel Becker <jlbec@evilplan.org>,
linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Daniel Rosenberg <drosen@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] configfs: Fix config_item refcnt error in __configfs_open_file()
Date: Thu, 11 Mar 2021 12:43:00 +0100 [thread overview]
Message-ID: <YEoCRFiDTool4g3Z@kroah.com> (raw)
In-Reply-To: <20210311113940.GA17668@lst.de>
On Thu, Mar 11, 2021 at 12:39:40PM +0100, Christoph Hellwig wrote:
> On Thu, Mar 11, 2021 at 12:35:10PM +0100, gregkh@linuxfoundation.org wrote:
> > From: Daniel Rosenberg <drosen@google.com>
> >
> > __configfs_open_file() used to use configfs_get_config_item, but changed
> > in commit b0841eefd969 ("configfs: provide exclusion between IO and
> > removals") to just call to_item. The error path still tries to clean up
> > the reference, incorrectly decrementing the ref count.
>
> This should already be covered by:
>
> http://git.infradead.org/users/hch/configfs.git/commitdiff/14fbbc8297728e880070f7b077b3301a8c698ef9
Yup, identical patch, sorry I missed that one, hopefully it hits Linus's
tree soon.
thanks,
greg k-h
prev parent reply other threads:[~2021-03-11 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 11:35 [PATCH v2] configfs: Fix config_item refcnt error in __configfs_open_file() gregkh
2021-03-11 11:39 ` Christoph Hellwig
2021-03-11 11:43 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEoCRFiDTool4g3Z@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=drosen@google.com \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox