From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91AABC433E0 for ; Tue, 16 Mar 2021 11:32:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3444665018 for ; Tue, 16 Mar 2021 11:32:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234945AbhCPLbd (ORCPT ); Tue, 16 Mar 2021 07:31:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:43654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237163AbhCPLbY (ORCPT ); Tue, 16 Mar 2021 07:31:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AB4B564ED2; Tue, 16 Mar 2021 11:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615894284; bh=/1wbkg2dCZqybDXCZgAdrsXjyaUVO/A5ZZTYvmkn8Ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fwAx788MXiFEsTW2UdN5X899XiI1QvdHGG+mozrxIlelVHZVlT1j6FtVkhYv1SU5V IpU5cgmYCyxXP5ITvP3C8lGm+DEZthd2rkFgKbuHZ/BD9tpnnjz3vrvubnqjI7QNYY BrR4UCTh30E7uJZYw9xJY5aMZPUIygo7/L+DZin8= Date: Tue, 16 Mar 2021 12:31:21 +0100 From: Greg KH To: Vladimir Murzin Cc: linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, dbrazdil@google.com Subject: Re: [PATCH][for-stable-v5.11]] arm64: Unconditionally set virtual cpu id registers Message-ID: References: <20210316112500.85268-1-vladimir.murzin@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316112500.85268-1-vladimir.murzin@arm.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Mar 16, 2021 at 11:25:00AM +0000, Vladimir Murzin wrote: > Commit 78869f0f0552 ("arm64: Extract parts of el2_setup into a macro") > reorganized el2 setup in such way that virtual cpu id registers set > only in nVHE, yet they used (and need) to be set irrespective VHE > support. Lack of setup causes 32-bit guest stop booting due to MIDR > stay undefined. > > Fixes: 78869f0f0552 ("arm64: Extract parts of el2_setup into a macro") > Signed-off-by: Vladimir Murzin > --- > > There is no upstream fix since issue went away due to code there has > been reworked in 5.12: nVHE comes first, so virtual cpu id register > are always set. > > Maintainers, please, Ack. Why not just use the "rework" patch instead that fixes this issue? that's always preferred instead of one-off patches. thanks, greg k-h