From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D1DC433DB for ; Thu, 18 Mar 2021 13:08:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B370164F65 for ; Thu, 18 Mar 2021 13:08:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231331AbhCRNIQ (ORCPT ); Thu, 18 Mar 2021 09:08:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:57906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231304AbhCRNHz (ORCPT ); Thu, 18 Mar 2021 09:07:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1EB6964F01; Thu, 18 Mar 2021 13:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616072875; bh=MG89MYSdpuKmskYRMKAcawmwc2DP/92dyzf8UU5Qem0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JMt09k8Cq0FEScH0OrQOE7qbQnKmSwP08X7vPCmznolggqk9F9v+L0pajV+Ko6ZUA g4HLdc6JkePldHMe/g5LlOQKINzNAeKkNzFl7BaIyam5ZKhFwN+CXHU2c5NN0809eM PaA/BF4n9Y9cEIRZGaoz+GQ+nwQAj3tjiQuDIF1yXucvIa7x3gbxR0IShD+mATWlSr OffF34b2JB6pIjet87fascqldPZMjF8p5ECOz2zi9T1+jZ1jLPsI7P7JErSlO7LEMz Q5GyP5eMwC3EKPMsLBWnlHlZBg5ha0dyjtDRbTBv72s/K9qVShv2e9P49L3tBDf2cJ tPfBNFIf6TSHA== Date: Thu, 18 Mar 2021 09:07:54 -0400 From: Sasha Levin To: Marc Zyngier Cc: Suzuki K Poulose , stable@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, alexandru.elisei@arm.com, christoffer.dall@arm.com Subject: Re: [PATCH] KVM: arm64: nvhe: Save the SPE context early Message-ID: References: <16157981451454@kroah.com> <20210316183353.4081445-1-suzuki.poulose@arm.com> <87eegdj2yf.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87eegdj2yf.wl-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Mar 17, 2021 at 01:59:36PM +0000, Marc Zyngier wrote: >On Tue, 16 Mar 2021 18:33:53 +0000, >Suzuki K Poulose wrote: >> >> commit b96b0c5de685df82019e16826a282d53d86d112c upstream >> >> The nVHE KVM hyp drains and disables the SPE buffer, before >> entering the guest, as the EL1&0 translation regime >> is going to be loaded with that of the guest. >> >> But this operation is performed way too late, because : >> - The owning translation regime of the SPE buffer >> is transferred to EL2. (MDCR_EL2_E2PB == 0) >> - The guest Stage1 is loaded. >> >> Thus the flush could use the host EL1 virtual address, >> but use the EL2 translations instead of host EL1, for writing >> out any cached data. >> >> Fix this by moving the SPE buffer handling early enough. >> The restore path is doing the right thing. >> >> Cc: stable@vger.kernel.org # v5.4- >> Cc: Christoffer Dall >> Cc: Marc Zyngier >> Cc: Will Deacon >> Cc: Catalin Marinas >> Cc: Mark Rutland >> Cc: Alexandru Elisei >> Signed-off-by: Suzuki K Poulose > >Acked-by: Marc Zyngier Queued up this and the 4.19 backport, thanks! -- Thanks, Sasha