From: Greg KH <gregkh@linuxfoundation.org>
To: Jianxiong Gao <jxgao@google.com>
Cc: stable@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH V2 v5.4 1/8] driver core: add a min_align_mask field to struct device_dma_parameters
Date: Wed, 7 Apr 2021 14:52:48 +0200 [thread overview]
Message-ID: <YG2rIASGZ89UnrlO@kroah.com> (raw)
In-Reply-To: <20210406204326.1932888-2-jxgao@google.com>
On Tue, Apr 06, 2021 at 08:43:20PM +0000, Jianxiong Gao wrote:
> 'commit 36950f2da1ea ("driver core: add a min_align_mask field to struct device_dma_parameters")'
>
> Some devices rely on the address offset in a page to function
> correctly (NVMe driver as an example). These devices may use
> a different page size than the Linux kernel. The address offset
> has to be preserved upon mapping, and in order to do so, we
> need to record the page_offset_mask first.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Jianxiong Gao <jxgao@google.com>
> Tested-by: Jianxiong Gao <jxgao@google.com>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Signed-off-by: Jianxiong Gao <jxgao@google.com>
> ---
> include/linux/device.h | 1 +
> include/linux/dma-mapping.h | 16 ++++++++++++++++
> 2 files changed, 17 insertions(+)
The signed-off-by area is still not correct with what is in Linus's
tree, how did you create this thing?
That does not bode well, so I'm dropping this whole series, see my
comments on the 5.10 series for details.
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-07 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 20:43 [PATCH V2 v5.4 0/8] preserve DMA offsets when using swiotlb Jianxiong Gao
2021-04-06 20:43 ` [PATCH V2 v5.4 1/8] driver core: add a min_align_mask field to struct device_dma_parameters Jianxiong Gao
2021-04-07 12:52 ` Greg KH [this message]
2021-04-06 20:43 ` [PATCH V2 v5.4 2/8] swiotlb: factor out an io_tlb_offset helper Jianxiong Gao
2021-04-06 20:43 ` [PATCH V2 v5.4 3/8] swiotlb: factor out a nr_slots helper Jianxiong Gao
2021-04-06 20:43 ` [PATCH V2 v5.4 4/8] swiotlb: clean up swiotlb_tbl_unmap_single Jianxiong Gao
2021-04-06 20:43 ` [PATCH V2 v5.4 5/8] swiotlb: refactor swiotlb_tbl_map_single Jianxiong Gao
2021-04-06 20:43 ` [PATCH V2 v5.4 6/8] swiotlb: don't modify orig_addr in swiotlb_tbl_sync_single Jianxiong Gao
2021-04-06 20:43 ` [PATCH V2 v5.4 7/8] swiotlb: respect min_align_mask Jianxiong Gao
2021-04-06 20:43 ` [PATCH V2 v5.4 8/8] nvme-pci: set min_align_mask Jianxiong Gao
2021-04-07 12:49 ` [PATCH V2 v5.4 0/8] preserve DMA offsets when using swiotlb Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG2rIASGZ89UnrlO@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jxgao@google.com \
--cc=konrad.wilk@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).