From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0293C433DB for ; Tue, 30 Mar 2021 16:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 820FF619CC for ; Tue, 30 Mar 2021 16:57:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232319AbhC3Q5H (ORCPT ); Tue, 30 Mar 2021 12:57:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:60064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232101AbhC3Q4n (ORCPT ); Tue, 30 Mar 2021 12:56:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B3BE761994; Tue, 30 Mar 2021 16:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617123402; bh=SqqV9Bgqaz1IcMK50Tp9FkcI1MYclQXsKQMXB24rokY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EMNBgQOcR3vHAcfYWlbr0ptXkTjwn+v0LOvQBFeYs7gBMuW3kM8jvkVByKmsnxSVA g2Yx193YUJUbBW99D/rozfk/v23ErvgC6JhNL9q5cgaa13u5Q6NcNZj/v3Cb/CJ9A2 e87c95zyMSgvRRu4wbKUzMc/cpQh6YwdX74hmFxMIKskTfjmS81pBQqdPdpOa8l95W 90kHvqHP17wW5QzDtGfwYRNIkZ+Cs/s4SfB9uHuX+NB4H6AehatUclRvXLroRc4nYT Eqdb3lcg1hHcU44vUiIJ9H2xOCnjQ2eWHIKDmHWLzqByBlVxjaup/pvfTZoUIyxWk9 oZnSHfWMLv1SA== Date: Tue, 30 Mar 2021 12:56:41 -0400 From: Sasha Levin To: Alexander Ovechkin Cc: stable@vger.kernel.org, edumazet@google.com, davem@davemloft.net, zeil@yandex-team.ru, dmtrmonakhov@yandex-team.ru, olegsenin@yandex-team.ru Subject: Re: [PATCH 4.19] tcp: relookup sock for RST+ACK packets handled by obsolete req sock Message-ID: References: <20210329175541.150651-1-ovov@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210329175541.150651-1-ovov@yandex-team.ru> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Mar 29, 2021 at 08:55:41PM +0300, Alexander Ovechkin wrote: >commit 7233da86697efef41288f8b713c10c2499cffe85 upstream. > >Currently tcp_check_req can be called with obsolete req socket for which big >socket have been already created (because of CPU race or early demux >assigning req socket to multiple packets in gro batch). > >Commit e0f9759f530bf789e984 ("tcp: try to keep packet if SYN_RCV race >is lost") added retry in case when tcp_check_req is called for PSH|ACK packet. >But if client sends RST+ACK immediatly after connection being >established (it is performing healthcheck, for example) retry does not >occur. In that case tcp_check_req tries to close req socket, >leaving big socket active. > >Fixes: e0f9759f530b ("tcp: try to keep packet if SYN_RCV race is lost") >Signed-off-by: Alexander Ovechkin >Reported-by: Oleg Senin Queued up, thanks! -- Thanks, Sasha