From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFC3C433ED for ; Wed, 21 Apr 2021 08:45:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98646613D7 for ; Wed, 21 Apr 2021 08:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235356AbhDUIqV (ORCPT ); Wed, 21 Apr 2021 04:46:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237038AbhDUIqU (ORCPT ); Wed, 21 Apr 2021 04:46:20 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A534C06138D for ; Wed, 21 Apr 2021 01:45:48 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id h4so31425009wrt.12 for ; Wed, 21 Apr 2021 01:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nF07lGmK8d790hYBNTxLzN+JqkeiBDMUtoFoxeafsPs=; b=PKuxgMvuAnY4j3XFS5LDSlKmE9K0hmcw+6xcrwyF5EYk7C+8Q8rY09FX5klV91bQ+H oxmSb48NV+BkZM2nurcQFUv1xeSoPd8ubDufrdjItZVFace8Vy9HXrRYrLCvASct4xst k2HVS4BbQnxp0VWuIYmqyQEC00n+oyX/PUzMbomZhrRxe1W5qS/8vi/xIpyFSfSRyQGR VD0ijrBlEJVy0twXMsrs3GbESBEL9NBaTOoV8sRIGfz8wN0dTLTFKO9tLjT7A+yyVTuj 95XwzYTffbWs4+c3mq8VdLDECQASB+DEPMqJcnV/smKRAqP6IVD5PKCha4TOYf9mBp/n 4DeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nF07lGmK8d790hYBNTxLzN+JqkeiBDMUtoFoxeafsPs=; b=e7K13i8o9s7SQSzB1TTtY6hEbnZcvhseaI3UY+rAiBv2X5W7PqFYpOgwt+NDm1YPfA PO/wwVg67QXnA65Prk+eciIfLZyhPku6XIMmTgC1ZBXtYmpmpbWqp9IbbayoQ3OzqAob XP4fypo2QQVGxhYkb1RMW8Xxb+oUfx6Tu6bfB1MBysGKu3seXzR/RbvxosPqpk9r9LnI dmkg66UTUuuOVPY8yeHWaj3fNZPDVgrNcJIV2WCDy2TClUZDxswSoLeDb7+dyLNqX7Ms 5loTy1Nsf6rINYB85Gnrc63HH6kHJczh3SLNbmizhHLwDJFA6EBy7ByJppRLcy3HaioL E9PQ== X-Gm-Message-State: AOAM532fLyf3ZhP1gVIzscKWP3NWc10QVNjBSDuld9NctnYgIrCdsJIl qw4U3Du3APFGoZRdR72Y215ZiQ== X-Google-Smtp-Source: ABdhPJxLbEgvbfDHrIA7WnlMIVdZHppOGkiCV3bbFTTWBqmRn3tbZ6PUlt6yVY2Qyreu5khHX/9XXQ== X-Received: by 2002:adf:f081:: with SMTP id n1mr25780163wro.137.1618994745796; Wed, 21 Apr 2021 01:45:45 -0700 (PDT) Received: from google.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id s8sm2246313wrn.97.2021.04.21.01.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 01:45:45 -0700 (PDT) Date: Wed, 21 Apr 2021 08:45:42 +0000 From: Quentin Perret To: Florian Fainelli Cc: Ard Biesheuvel , Rob Herring , Alexandre TORGUE , Greg Kroah-Hartman , Sasha Levin , stable , Arnd Bergmann , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Nicolas Boichat , Stephen Boyd , KarimAllah Ahmed , Android Kernel Team , Architecture Mailman List , Frank Rowand , linux-arm-kernel Subject: Re: [v5.4 stable] arm: stm32: Regression observed on "no-map" reserved memory region Message-ID: References: <4a4734d6-49df-677b-71d3-b926c44d89a9@foss.st.com> <001f8550-b625-17d2-85a6-98a483557c70@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wednesday 21 Apr 2021 at 08:31:00 (+0000), Quentin Perret wrote: > FWIW I did test this on Qemu before posting. With 5.12-rc8 and a 1MiB > no-map region at 0x80000000, I have the following: > > 40000000-7fffffff : System RAM > 40210000-417fffff : Kernel code > 41800000-41daffff : reserved > 41db0000-4210ffff : Kernel data > 48000000-48008fff : reserved > 80000000-800fffff : reserved > 80100000-13fffffff : System RAM > fa000000-ffffffff : reserved > 13b000000-13f5fffff : reserved > 13f6de000-13f77dfff : reserved > 13f77e000-13f77efff : reserved > 13f77f000-13f7dafff : reserved > 13f7dd000-13f7defff : reserved > 13f7df000-13f7dffff : reserved > 13f7e0000-13f7f3fff : reserved > 13f7f4000-13f7fdfff : reserved > 13f7fe000-13fffffff : reserved > > If I remove the 'no-map' qualifier from DT, I get this: > > 40000000-13fffffff : System RAM > 40210000-417fffff : Kernel code > 41800000-41daffff : reserved > 41db0000-4210ffff : Kernel data > 48000000-48008fff : reserved > 80000000-800fffff : reserved > fa000000-ffffffff : reserved > 13b000000-13f5fffff : reserved > 13f6de000-13f77dfff : reserved > 13f77e000-13f77efff : reserved > 13f77f000-13f7dafff : reserved > 13f7dd000-13f7defff : reserved > 13f7df000-13f7dffff : reserved > 13f7e0000-13f7f3fff : reserved > 13f7f4000-13f7fdfff : reserved > 13f7fe000-13fffffff : reserved > > So this does seem to be working fine on my setup. I'll try again with > 5.4 to see if I can repro. I just ran the same experiment on v5.4.102 which is where the regression was reported, and I'm seeing the same correct result... > Also, 8a5a75e5e9e5 ("of/fdt: Make sure no-map does not remove already > reserved regions") looks more likely to cause the issue observed here, > but that shouldn't be silent. I get the following error message in dmesg > if I if place the no-map region on top of the kernel image: > > OF: fdt: Reserved memory: failed to reserve memory for node 'foobar@40210000': base 0x0000000040210000, size 1 MiB > > Is that triggering on your end? So that really sounds like the cause of the issue here, though arguably this should be indicative a something funny in the DT. Thanks, Quentin