public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: reijiw@google.com, jmattson@google.com, pbonzini@redhat.com,
	stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] KVM: VMX: Don't use vcpu->run->internal.ndata as an array" failed to apply to 5.11-stable tree
Date: Sun, 18 Apr 2021 20:29:16 -0400	[thread overview]
Message-ID: <YHzO3D2cjuJ9f+ZW@sashalap> (raw)
In-Reply-To: <1618742076194222@kroah.com>

On Sun, Apr 18, 2021 at 12:34:36PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.11-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 04c4f2ee3f68c9a4bf1653d15f1a9a435ae33f7a Mon Sep 17 00:00:00 2001
>From: Reiji Watanabe <reijiw@google.com>
>Date: Tue, 13 Apr 2021 15:47:40 +0000
>Subject: [PATCH] KVM: VMX: Don't use vcpu->run->internal.ndata as an array
> index
>
>__vmx_handle_exit() uses vcpu->run->internal.ndata as an index for
>an array access.  Since vcpu->run is (can be) mapped to a user address
>space with a writer permission, the 'ndata' could be updated by the
>user process at anytime (the user process can set it to outside the
>bounds of the array).
>So, it is not safe that __vmx_handle_exit() uses the 'ndata' that way.
>
>Fixes: 1aa561b1a4c0 ("kvm: x86: Add "last CPU" to some KVM_EXIT information")
>Signed-off-by: Reiji Watanabe <reijiw@google.com>
>Reviewed-by: Jim Mattson <jmattson@google.com>
>Message-Id: <20210413154739.490299-1-reijiw@google.com>
>Cc: stable@vger.kernel.org
>Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

I've resolved this by taking 8e5332402164 ("KVM: VMX: Convert
vcpu_vmx.exit_reason to a union").

-- 
Thanks,
Sasha

      reply	other threads:[~2021-04-19  0:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18 10:34 FAILED: patch "[PATCH] KVM: VMX: Don't use vcpu->run->internal.ndata as an array" failed to apply to 5.11-stable tree gregkh
2021-04-19  0:29 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHzO3D2cjuJ9f+ZW@sashalap \
    --to=sashal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jmattson@google.com \
    --cc=pbonzini@redhat.com \
    --cc=reijiw@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox