RDMA/i40iw: Avoid panic when reading back the IRQ affinity hint

RDMA/i40iw: Avoid panic when reading back the IRQ affinity hint

[Edwin Peer]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

Hello stable team,

Please consider adding the following upstream commit to the 4.14 stable series:

commit 43731753c4b7d832775cf6b2301dd0447a5a1851
Author: Andrew Boyer <andrew.boyer@dell.com>
Date:   Mon May 7 13:23:38 2018 -0400

RDMA/i40iw: Avoid panic when reading back the IRQ affinity hint

The current code sets an affinity hint with a cpumask_t stored on the
stack. This value can then be accessed through /proc/irq/*/affinity_hint/,
causing a segfault or returning corrupt data.

Move the cpumask_t into struct i40iw_msix_vector so it is available later.
...
...
...
Fixes: 8e06af711bf2 ("i40iw: add main, hdr, status")
Signed-off-by: Andrew Boyer <andrew.boyer@dell.com>
Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

Note, the fixes tag above appears to be incorrect. The problem was
introduced in:

commit e69c5093617afdbd2ab02c289d0adaac044dff66
Author: Henry Orosco <henry.orosco@intel.com>
Date:   Wed Nov 9 21:24:48 2016 -0600

i40iw: Use vector when creating CQs

Assign each CEQ vector to a different CPU when possible, then
when creating a CQ, use the vector for the CEQ id. This
allows completion work to be distributed over multiple cores.

Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
Signed-off-by: Henry Orosco <henry.orosco@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

Thus, affected kernels range from 4.10 to pre 4.17.

Regards,
Edwin Peer

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4203 bytes --]

Re: RDMA/i40iw: Avoid panic when reading back the IRQ affinity hint

[Greg KH]

On Thu, May 13, 2021 at 09:34:46AM -0700, Edwin Peer wrote:
> Hello stable team,
> 
> Please consider adding the following upstream commit to the 4.14 stable series:
> 
> commit 43731753c4b7d832775cf6b2301dd0447a5a1851
> Author: Andrew Boyer <andrew.boyer@dell.com>
> Date:   Mon May 7 13:23:38 2018 -0400
> 
> RDMA/i40iw: Avoid panic when reading back the IRQ affinity hint
> 
> The current code sets an affinity hint with a cpumask_t stored on the
> stack. This value can then be accessed through /proc/irq/*/affinity_hint/,
> causing a segfault or returning corrupt data.
> 
> Move the cpumask_t into struct i40iw_msix_vector so it is available later.
> ...
> ...
> ...
> Fixes: 8e06af711bf2 ("i40iw: add main, hdr, status")
> Signed-off-by: Andrew Boyer <andrew.boyer@dell.com>
> Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com>
> Signed-off-by: Doug Ledford <dledford@redhat.com>
> 
> Note, the fixes tag above appears to be incorrect. The problem was
> introduced in:
> 
> commit e69c5093617afdbd2ab02c289d0adaac044dff66
> Author: Henry Orosco <henry.orosco@intel.com>
> Date:   Wed Nov 9 21:24:48 2016 -0600
> 
> i40iw: Use vector when creating CQs
> 
> Assign each CEQ vector to a different CPU when possible, then
> when creating a CQ, use the vector for the CEQ id. This
> allows completion work to be distributed over multiple cores.
> 
> Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
> Signed-off-by: Henry Orosco <henry.orosco@intel.com>
> Signed-off-by: Doug Ledford <dledford@redhat.com>
> 
> Thus, affected kernels range from 4.10 to pre 4.17.
> 
> Regards,
> Edwin Peer

Now queued up, thanks.

greg k-h