From: Greg KH <gregkh@linuxfoundation.org>
To: Jianxiong Gao <jxgao@google.com>
Cc: stable@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Marc Orr <marcorr@google.com>,
sashal@kernel.org
Subject: Re: [PATCH 5.4 v2 0/9] preserve DMA offsets when using swiotlb
Date: Wed, 19 May 2021 19:03:22 +0200 [thread overview]
Message-ID: <YKVE2kerpTzoeIL+@kroah.com> (raw)
In-Reply-To: <CAMGD6P1FBwYBnVPPSFtn0qgHbs+y=stZXhnYHjX82H+vqei+AQ@mail.gmail.com>
On Wed, May 19, 2021 at 09:42:42AM -0700, Jianxiong Gao wrote:
> On Wed, May 19, 2021 at 1:11 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > I still fail to understand why you can not just use the 5.10.y kernel or
> > newer. What is preventing you from doing this if you wish to use this
> > type of hardware? This is not a "regression" in that the 5.4.y kernel
> > has never worked with this hardware before, it feels like a new feature.
> >
> NVMe + SWIOTLB is not a new feature. From my understanding it should
> be supported by 5.4.y kernel correctly. Currently without the patch, any
> NVMe device (along with some other devices that relies on offset to
> work correctly), could be broken if the SWIOTLB is used on a 5.4.y kernel.
Then do not do that, as obviously it never worked without your fixes, so
this isn't a "regression".
And again, why can you not just use 5.10.y?
thanks,
greg k-h
next prev parent reply other threads:[~2021-05-19 17:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 22:18 [PATCH 5.4 v2 0/9] preserve DMA offsets when using swiotlb Jianxiong Gao
2021-05-18 22:18 ` [PATCH 5.4 v2 1/9] driver core: add a min_align_mask field to struct device_dma_parameters Jianxiong Gao
2021-05-18 22:18 ` [PATCH 5.4 v2 2/9] swiotlb: add a IO_TLB_SIZE define Jianxiong Gao
2021-05-18 22:18 ` [PATCH 5.4 v2 3/9] swiotlb: factor out an io_tlb_offset helper Jianxiong Gao
2021-05-18 22:18 ` [PATCH 5.4 v2 4/9] swiotlb: factor out a nr_slots helper Jianxiong Gao
2021-05-18 22:18 ` [PATCH 5.4 v2 5/9] swiotlb: clean up swiotlb_tbl_unmap_single Jianxiong Gao
2021-05-18 22:18 ` [PATCH 5.4 v2 6/9] swiotlb: refactor swiotlb_tbl_map_single Jianxiong Gao
2021-05-18 22:18 ` [PATCH 5.4 v2 7/9] swiotlb: don't modify orig_addr in swiotlb_tbl_sync_single Jianxiong Gao
2021-05-18 22:18 ` [PATCH 5.4 v2 8/9] swiotlb: respect min_align_mask Jianxiong Gao
2021-05-18 22:18 ` [PATCH 5.4 v2 9/9] nvme-pci: set min_align_mask Jianxiong Gao
2021-05-19 8:11 ` [PATCH 5.4 v2 0/9] preserve DMA offsets when using swiotlb Greg KH
2021-05-19 16:42 ` Jianxiong Gao
2021-05-19 17:03 ` Greg KH [this message]
2021-05-19 17:18 ` Marc Orr
2021-05-19 17:25 ` Greg KH
2021-05-19 20:01 ` Marc Orr
2021-05-20 8:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKVE2kerpTzoeIL+@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jxgao@google.com \
--cc=marcorr@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox