From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Tsoy <alexander@tsoy.me>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
"David S. Miller" <davem@davemloft.net>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.10 35/38] rtnetlink: Fix missing error code in rtnl_bridge_notify()
Date: Sat, 19 Jun 2021 08:45:57 +0200 [thread overview]
Message-ID: <YM2SpRA5lgMNP1W3@kroah.com> (raw)
In-Reply-To: <fb24ef9ad94f8b052407c5bdd4e3815675b89213.camel@tsoy.me>
On Sat, Jun 19, 2021 at 02:58:28AM +0300, Alexander Tsoy wrote:
> В Ср, 16/06/2021 в 17:33 +0200, Greg Kroah-Hartman пишет:
> > From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> >
> > [ Upstream commit a8db57c1d285c758adc7fb43d6e2bad2554106e1 ]
> >
> > The error code is missing in this code scenario, add the error code
> > '-EINVAL' to the return value 'err'.
> >
> > Eliminate the follow smatch warning:
> >
> > net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
> > 'err'.
>
> This patch breaks systemd-resolved. It is 100% reproducible on two of
> my systems, but there are also systems where I cannot reproduce it. The
> problem manifests itself as SERVFAIL on every DNS query.
>
> Just reverting this patch from 5.10.45 fixes the problem for me.
Is Linus's tree also broken for you? It should be reverted there first.
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-19 6:54 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 15:33 [PATCH 5.10 00/38] 5.10.45-rc1 review Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 01/38] net: ieee802154: fix null deref in parse dev addr Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 02/38] HID: quirks: Set INCREMENT_USAGE_ON_DUPLICATE for Saitek X65 Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 03/38] HID: a4tech: use A4_2WHEEL_MOUSE_HACK_B8 for A4TECH NB-95 Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 04/38] HID: hid-input: add mapping for emoji picker key Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 05/38] HID: hid-sensor-hub: Return error for hid_set_field() failure Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 06/38] HID: quirks: Add quirk for Lenovo optical mouse Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 07/38] HID: multitouch: set Stylus suffix for Stylus-application devices, too Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 08/38] HID: Add BUS_VIRTUAL to hid_connect logging Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 09/38] HID: usbhid: fix info leak in hid_submit_ctrl Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 10/38] drm/tegra: sor: Do not leak runtime PM reference Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 11/38] gpu: host1x: Split up client initalization and registration Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 12/38] drm/tegra: sor: Fully initialize SOR before registration Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 13/38] ARM: OMAP1: Fix use of possibly uninitialized irq variable Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 14/38] ARM: OMAP2+: Fix build warning when mmc_omap is not built Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 15/38] gfs2: Prevent direct-I/O write fallback errors from getting lost Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 16/38] gfs2: fix a deadlock on withdraw-during-mount Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 17/38] HID: gt683r: add missing MODULE_DEVICE_TABLE Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 18/38] riscv: Use -mno-relax when using lld linker Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 19/38] gfs2: Fix use-after-free in gfs2_glock_shrink_scan Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 20/38] scsi: target: core: Fix warning on realtime kernels Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 21/38] ethernet: myri10ge: Fix missing error code in myri10ge_probe() Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 22/38] scsi: qedf: Do not put host in qedf_vport_create() unconditionally Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 23/38] Bluetooth: Add a new USB ID for RTL8822CE Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 24/38] scsi: scsi_devinfo: Add blacklist entry for HPE OPEN-V Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 25/38] nvme-loop: reset queue count to 1 in nvme_loop_destroy_io_queues() Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 26/38] nvme-loop: clear NVME_LOOP_Q_LIVE when nvme_loop_configure_admin_queue() fails Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 27/38] nvme-loop: check for NVME_LOOP_Q_LIVE in nvme_loop_destroy_admin_queue() Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 28/38] nvme-loop: do not warn for deleted controllers during reset Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 29/38] net: ipconfig: Dont override command-line hostnames or domains Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 30/38] drm/amd/display: Allow bandwidth validation for 0 streams Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 31/38] drm/amdgpu: refine amdgpu_fru_get_product_info Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 32/38] drm/amd/display: Fix overlay validation by considering cursors Greg Kroah-Hartman
2021-06-16 16:02 ` Harry Wentland
2021-06-16 15:33 ` [PATCH 5.10 33/38] drm/amd/display: Fix potential memory leak in DMUB hw_init Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 34/38] drm/amd/amdgpu:save psp ring wptr to avoid attack Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 35/38] rtnetlink: Fix missing error code in rtnl_bridge_notify() Greg Kroah-Hartman
2021-06-18 23:58 ` Alexander Tsoy
2021-06-19 6:45 ` Greg Kroah-Hartman [this message]
2021-06-19 13:06 ` Alexander Tsoy
2021-06-16 15:33 ` [PATCH 5.10 36/38] net/x25: Return the correct errno code Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 37/38] net: " Greg Kroah-Hartman
2021-06-16 15:33 ` [PATCH 5.10 38/38] fib: " Greg Kroah-Hartman
2021-06-16 18:49 ` [PATCH 5.10 00/38] 5.10.45-rc1 review Jon Hunter
2021-06-16 21:07 ` Fox Chen
2021-06-16 22:40 ` Florian Fainelli
2021-06-17 6:51 ` Pavel Machek
2021-06-17 9:04 ` Naresh Kamboju
2021-06-17 10:27 ` Samuel Zou
2021-06-17 11:00 ` Sudip Mukherjee
2021-06-17 21:39 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YM2SpRA5lgMNP1W3@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abaci@linux.alibaba.com \
--cc=alexander@tsoy.me \
--cc=davem@davemloft.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox