From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA49DC2B9F4 for ; Thu, 17 Jun 2021 04:51:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92168613BF for ; Thu, 17 Jun 2021 04:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229599AbhFQExQ (ORCPT ); Thu, 17 Jun 2021 00:53:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:34392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229673AbhFQExO (ORCPT ); Thu, 17 Jun 2021 00:53:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 720B16023D; Thu, 17 Jun 2021 04:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623905467; bh=zhj/r02l03A3GGfq/13KwbHx9LGSapVvInAka2yMdDA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tyWMMcsKO83TGp2IXYb21OvpqgvfvItq86/osfFc1CmmVgqOrYyg4qe1op5rQ1dUz YjbNg5SDFz1KNnOz0xHNFN8pUkUXz9ZM6wH9X/kQOxDn2A5dPAyPolbWDLj6n0I84O 6tPhkdooNG8sswZHsI7WEZ8BKqqUiIw98o17b6wA= Date: Thu, 17 Jun 2021 06:51:03 +0200 From: Greg Kroah-Hartman To: Aman Priyadarshi Cc: Marc Zyngier , Will Deacon , Alexander Graf , Mark Rutland , stable@vger.kernel.org, Ali Saidi Subject: Re: [PATCH] arm64: perf: Disable PMU while processing counter overflows Message-ID: References: <20210616192859.21708-1-apeureka@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210616192859.21708-1-apeureka@amazon.de> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jun 16, 2021 at 09:28:59PM +0200, Aman Priyadarshi wrote: > From: Suzuki K Poulose > > [ Upstream commit 3cce50dfec4a5b0414c974190940f47dd32c6dee ] > > The arm64 PMU updates the event counters and reprograms the > counters in the overflow IRQ handler without disabling the > PMU. This could potentially cause skews in for group counters, > where the overflowed counters may potentially loose some event > counts, while they are reprogrammed. To prevent this, disable > the PMU while we process the counter overflows and enable it > right back when we are done. > > This patch also moves the PMU stop/start routines to avoid a > forward declaration. > > Suggested-by: Mark Rutland > Cc: Will Deacon > Acked-by: Mark Rutland > Signed-off-by: Suzuki K Poulose > Signed-off-by: Will Deacon > Signed-off-by: Aman Priyadarshi > Cc: stable@vger.kernel.org > --- > arch/arm64/kernel/perf_event.c | 50 +++++++++++++++++++--------------- > 1 file changed, 28 insertions(+), 22 deletions(-) What stable tree(s) do you want this applied to? thanks, greg k-h