From: Sasha Levin <sashal@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH 4.4 to 4.19] Makefile: Move -Wno-unused-but-set-variable out of GCC only block
Date: Thu, 24 Jun 2021 08:04:41 -0400 [thread overview]
Message-ID: <YNR02aQT3f9Naap/@sashalap> (raw)
In-Reply-To: <20210623172610.3281050-1-nathan@kernel.org>
On Wed, Jun 23, 2021 at 10:26:12AM -0700, Nathan Chancellor wrote:
>commit 885480b084696331bea61a4f7eba10652999a9c1 upstream.
>
>Currently, -Wunused-but-set-variable is only supported by GCC so it is
>disabled unconditionally in a GCC only block (it is enabled with W=1).
>clang currently has its implementation for this warning in review so
>preemptively move this statement out of the GCC only block and wrap it
>with cc-disable-warning so that both compilers function the same.
>
>Cc: stable@vger.kernel.org
>Link: https://reviews.llvm.org/D100581
>Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>Tested-by: Nick Desaulniers <ndesaulniers@google.com>
>Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>[nc: Backport, workaround lack of e2079e93f562 in older branches]
Can we just take the above patch instead?
--
Thanks,
Sasha
next prev parent reply other threads:[~2021-06-24 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 17:26 [PATCH 4.4 to 4.19] Makefile: Move -Wno-unused-but-set-variable out of GCC only block Nathan Chancellor
2021-06-24 12:04 ` Sasha Levin [this message]
2021-06-24 16:36 ` Nathan Chancellor
2021-06-25 10:10 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNR02aQT3f9Naap/@sashalap \
--to=sashal@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox