From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F311FC2B9F4 for ; Fri, 25 Jun 2021 10:22:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFDA66143B for ; Fri, 25 Jun 2021 10:22:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230379AbhFYKYo (ORCPT ); Fri, 25 Jun 2021 06:24:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:44912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230436AbhFYKYn (ORCPT ); Fri, 25 Jun 2021 06:24:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EA86B61439; Fri, 25 Jun 2021 10:22:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624616542; bh=TOcbaUztKO2e1mYBAw64ee9NuniluuPC6ZDvM9kA/og=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LQNjrYcoFkrpO0bIRBGwclSHx9DAvYUCLsr6tfIbXR6zdbWTVPR5a8tHHJNbHjFe1 1ot4WlRffIed6w1JGCfeZmmTm9K8B23dPQCwWQ1PV24T6ZozyOfttVRRvp61uXyIvO hy6xDZC0j4DcbRILLnD7T2RSfYhfSkxY02i0QkTI= Date: Fri, 25 Jun 2021 12:22:19 +0200 From: Greg Kroah-Hartman To: Aman Priyadarshi Cc: Marc Zyngier , Will Deacon , Alexander Graf , Mark Rutland , stable@vger.kernel.org, Ali Saidi Subject: Re: [PATCH] arm64: perf: Disable PMU while processing counter overflows Message-ID: References: <20210616192859.21708-1-apeureka@amazon.de> <87r1h1c5bo.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Jun 17, 2021 at 10:57:00AM +0200, Aman Priyadarshi wrote: > On Thu, 2021-06-17 at 08:34 +0100, Marc Zyngier wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and > > know the content is safe. > > > > > > > > On Thu, 17 Jun 2021 05:51:03 +0100, > > Greg Kroah-Hartman wrote: > > > > > > On Wed, Jun 16, 2021 at 09:28:59PM +0200, Aman Priyadarshi wrote: > > > > From: Suzuki K Poulose > > > > > > > > [ Upstream commit 3cce50dfec4a5b0414c974190940f47dd32c6dee ] > > > > > > > > The arm64 PMU updates the event counters and reprograms the > > > > counters in the overflow IRQ handler without disabling the > > > > PMU. This could potentially cause skews in for group counters, > > > > where the overflowed counters may potentially loose some event > > > > counts, while they are reprogrammed. To prevent this, disable > > > > the PMU while we process the counter overflows and enable it > > > > right back when we are done. > > > > > > > > This patch also moves the PMU stop/start routines to avoid a > > > > forward declaration. > > > > > > > > Suggested-by: Mark Rutland > > > > Cc: Will Deacon > > > > Acked-by: Mark Rutland > > > > Signed-off-by: Suzuki K Poulose > > > > Signed-off-by: Will Deacon > > > > Signed-off-by: Aman Priyadarshi > > > > Cc: stable@vger.kernel.org > > > > --- > > > > arch/arm64/kernel/perf_event.c | 50 +++++++++++++++++++------------- > > > > -- > > > > 1 file changed, 28 insertions(+), 22 deletions(-) > > > > > > What stable tree(s) do you want this applied to? > > > > I guess that'd be 4.14 and previous stables if the patch actually > > applies. > > > > Correct. I have tested the patch on 4.14.y, can confirm that it applies > cleanly on 4.9.y as well. Now queued up, thanks. greg k-h