From: Greg KH <greg@kroah.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: stable@vger.kernel.org, dhowells@redhat.com,
Andrew W Elble <aweits@rit.edu>
Subject: Re: [PATCH][RESEND] ceph: fix test for whether we can skip read when writing beyond EOF
Date: Mon, 28 Jun 2021 14:21:44 +0200 [thread overview]
Message-ID: <YNm+2KlzX2oLOx4p@kroah.com> (raw)
In-Reply-To: <20210627163929.15768-1-jlayton@kernel.org>
On Sun, Jun 27, 2021 at 12:39:29PM -0400, Jeff Layton wrote:
> It's not sufficient to skip reading when the pos is beyond the EOF.
> There may be data at the head of the page that we need to fill in
> before the write.
>
> Add a new helper function that corrects and clarifies the logic of
> when we can skip reads, and have it only zero out the part of the page
> that won't have data copied in for the write.
>
> [ Note: this fix is commit 827a746f405d in mainline kernels. The
> original bug was in ceph, but got lifted into the fs/netfs
> library for v5.13. This backport should apply to stable
> kernels v5.10 though v5.12. ]
>
That helped, thanks for resending this. Now queued up.
greg k-h
prev parent reply other threads:[~2021-06-28 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 16:39 [PATCH][RESEND] ceph: fix test for whether we can skip read when writing beyond EOF Jeff Layton
2021-06-28 12:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNm+2KlzX2oLOx4p@kroah.com \
--to=greg@kroah.com \
--cc=aweits@rit.edu \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox