* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM [not found] <20210408230001.310215-1-marex@denx.de> @ 2021-06-28 10:44 ` Marek Vasut 2021-06-28 12:29 ` Greg KH 0 siblings, 1 reply; 7+ messages in thread From: Marek Vasut @ 2021-06-28 10:44 UTC (permalink / raw) To: linux-arm-kernel, linux-stable Cc: Alexandre Torgue, Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin On 4/9/21 1:00 AM, Marek Vasut wrote: > The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be > enabled when the nRST is toggled according to datasheet Microchip > LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset: [...] > Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board") Adding stable to CC. Patch is now part of Linux 5.13 as commit 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM") It would be nice to pick it into stable, since it fixes ethernet stability issues on the device. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM 2021-06-28 10:44 ` [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM Marek Vasut @ 2021-06-28 12:29 ` Greg KH 2021-06-28 12:32 ` Marek Vasut 0 siblings, 1 reply; 7+ messages in thread From: Greg KH @ 2021-06-28 12:29 UTC (permalink / raw) To: Marek Vasut Cc: linux-arm-kernel, linux-stable, Alexandre Torgue, Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote: > On 4/9/21 1:00 AM, Marek Vasut wrote: > > The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be > > enabled when the nRST is toggled according to datasheet Microchip > > LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset: > > [...] > > > Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board") > > Adding stable to CC. > > Patch is now part of Linux 5.13 as commit > > 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM") $ git show 1cebcf9932ab fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]' Are you sure? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM 2021-06-28 12:29 ` Greg KH @ 2021-06-28 12:32 ` Marek Vasut 2021-06-28 13:02 ` Greg KH 0 siblings, 1 reply; 7+ messages in thread From: Marek Vasut @ 2021-06-28 12:32 UTC (permalink / raw) To: Greg KH Cc: linux-arm-kernel, linux-stable, Alexandre Torgue, Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin On 6/28/21 2:29 PM, Greg KH wrote: > On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote: >> On 4/9/21 1:00 AM, Marek Vasut wrote: >>> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be >>> enabled when the nRST is toggled according to datasheet Microchip >>> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset: >> >> [...] >> >>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board") >> >> Adding stable to CC. >> >> Patch is now part of Linux 5.13 as commit >> >> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM") > > $ git show 1cebcf9932ab > fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree. > Use '--' to separate paths from revisions, like this: > 'git <command> [<revision>...] -- [<file>...]' > > Are you sure? This would seem to indicate so: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956 linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956 v5.13-rc1-1-g1cebcf9932ab Did the commit get abbreviated too much ? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM 2021-06-28 12:32 ` Marek Vasut @ 2021-06-28 13:02 ` Greg KH 2021-06-28 13:10 ` Marek Vasut 0 siblings, 1 reply; 7+ messages in thread From: Greg KH @ 2021-06-28 13:02 UTC (permalink / raw) To: Marek Vasut Cc: linux-arm-kernel, linux-stable, Alexandre Torgue, Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote: > On 6/28/21 2:29 PM, Greg KH wrote: > > On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote: > > > On 4/9/21 1:00 AM, Marek Vasut wrote: > > > > The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be > > > > enabled when the nRST is toggled according to datasheet Microchip > > > > LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset: > > > > > > [...] > > > > > > > Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board") > > > > > > Adding stable to CC. > > > > > > Patch is now part of Linux 5.13 as commit > > > > > > 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM") > > > > $ git show 1cebcf9932ab > > fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree. > > Use '--' to separate paths from revisions, like this: > > 'git <command> [<revision>...] -- [<file>...]' > > > > Are you sure? > > This would seem to indicate so: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956 > > linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956 > v5.13-rc1-1-g1cebcf9932ab > > Did the commit get abbreviated too much ? Something is really odd, as that commit _is_ in linux-next, but it is not in my local copy of Linus's tree. So how it is showing up in that link above is beyond me. Can you see it locally on your machine? thanks, greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM 2021-06-28 13:02 ` Greg KH @ 2021-06-28 13:10 ` Marek Vasut 2021-06-28 13:38 ` Greg KH 0 siblings, 1 reply; 7+ messages in thread From: Marek Vasut @ 2021-06-28 13:10 UTC (permalink / raw) To: Greg KH Cc: linux-arm-kernel, linux-stable, Alexandre Torgue, Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin On 6/28/21 3:02 PM, Greg KH wrote: > On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote: >> On 6/28/21 2:29 PM, Greg KH wrote: >>> On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote: >>>> On 4/9/21 1:00 AM, Marek Vasut wrote: >>>>> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be >>>>> enabled when the nRST is toggled according to datasheet Microchip >>>>> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset: >>>> >>>> [...] >>>> >>>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board") >>>> >>>> Adding stable to CC. >>>> >>>> Patch is now part of Linux 5.13 as commit >>>> >>>> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM") >>> >>> $ git show 1cebcf9932ab >>> fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree. >>> Use '--' to separate paths from revisions, like this: >>> 'git <command> [<revision>...] -- [<file>...]' >>> >>> Are you sure? >> >> This would seem to indicate so: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956 >> >> linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956 >> v5.13-rc1-1-g1cebcf9932ab >> >> Did the commit get abbreviated too much ? > > Something is really odd, as that commit _is_ in linux-next, but it is > not in my local copy of Linus's tree. > > So how it is showing up in that link above is beyond me. Can you see it > locally on your machine? Yes, that's where the git describe came from. And I used a different repo than the one from which I submitted the patch originally, so the commit must've come from fetching origin (i.e. linus tree). Could it be this "ambiguous argument '1cebcf9932ab'" , which would indicate the commit hash got abbreviated too much ? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM 2021-06-28 13:10 ` Marek Vasut @ 2021-06-28 13:38 ` Greg KH 2021-06-28 13:58 ` Marek Vasut 0 siblings, 1 reply; 7+ messages in thread From: Greg KH @ 2021-06-28 13:38 UTC (permalink / raw) To: Marek Vasut Cc: linux-arm-kernel, linux-stable, Alexandre Torgue, Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin On Mon, Jun 28, 2021 at 03:10:36PM +0200, Marek Vasut wrote: > On 6/28/21 3:02 PM, Greg KH wrote: > > On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote: > > > On 6/28/21 2:29 PM, Greg KH wrote: > > > > On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote: > > > > > On 4/9/21 1:00 AM, Marek Vasut wrote: > > > > > > The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be > > > > > > enabled when the nRST is toggled according to datasheet Microchip > > > > > > LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset: > > > > > > > > > > [...] > > > > > > > > > > > Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board") > > > > > > > > > > Adding stable to CC. > > > > > > > > > > Patch is now part of Linux 5.13 as commit > > > > > > > > > > 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM") > > > > > > > > $ git show 1cebcf9932ab > > > > fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree. > > > > Use '--' to separate paths from revisions, like this: > > > > 'git <command> [<revision>...] -- [<file>...]' > > > > > > > > Are you sure? > > > > > > This would seem to indicate so: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956 > > > > > > linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956 > > > v5.13-rc1-1-g1cebcf9932ab > > > > > > Did the commit get abbreviated too much ? > > > > Something is really odd, as that commit _is_ in linux-next, but it is > > not in my local copy of Linus's tree. > > > > So how it is showing up in that link above is beyond me. Can you see it > > locally on your machine? > > Yes, that's where the git describe came from. And I used a different repo > than the one from which I submitted the patch originally, so the commit > must've come from fetching origin (i.e. linus tree). > > Could it be this "ambiguous argument '1cebcf9932ab'" , which would indicate > the commit hash got abbreviated too much ? The web site "lies" it has a shared backend. Trust your local copy of the tree, that shows that this commit is NOT in Linus's tree just yet. Please let stable@vger know when it does hit Linus's tree and we will be glad to take it. thanks, greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM 2021-06-28 13:38 ` Greg KH @ 2021-06-28 13:58 ` Marek Vasut 0 siblings, 0 replies; 7+ messages in thread From: Marek Vasut @ 2021-06-28 13:58 UTC (permalink / raw) To: Greg KH Cc: linux-arm-kernel, linux-stable, Alexandre Torgue, Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin On 6/28/21 3:38 PM, Greg KH wrote: > On Mon, Jun 28, 2021 at 03:10:36PM +0200, Marek Vasut wrote: >> On 6/28/21 3:02 PM, Greg KH wrote: >>> On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote: >>>> On 6/28/21 2:29 PM, Greg KH wrote: >>>>> On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote: >>>>>> On 4/9/21 1:00 AM, Marek Vasut wrote: >>>>>>> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be >>>>>>> enabled when the nRST is toggled according to datasheet Microchip >>>>>>> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset: >>>>>> >>>>>> [...] >>>>>> >>>>>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board") >>>>>> >>>>>> Adding stable to CC. >>>>>> >>>>>> Patch is now part of Linux 5.13 as commit >>>>>> >>>>>> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM") >>>>> >>>>> $ git show 1cebcf9932ab >>>>> fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree. >>>>> Use '--' to separate paths from revisions, like this: >>>>> 'git <command> [<revision>...] -- [<file>...]' >>>>> >>>>> Are you sure? >>>> >>>> This would seem to indicate so: >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956 >>>> >>>> linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956 >>>> v5.13-rc1-1-g1cebcf9932ab >>>> >>>> Did the commit get abbreviated too much ? >>> >>> Something is really odd, as that commit _is_ in linux-next, but it is >>> not in my local copy of Linus's tree. >>> >>> So how it is showing up in that link above is beyond me. Can you see it >>> locally on your machine? >> >> Yes, that's where the git describe came from. And I used a different repo >> than the one from which I submitted the patch originally, so the commit >> must've come from fetching origin (i.e. linus tree). >> >> Could it be this "ambiguous argument '1cebcf9932ab'" , which would indicate >> the commit hash got abbreviated too much ? > > The web site "lies" it has a shared backend. Trust your local copy of > the tree, that shows that this commit is NOT in Linus's tree just yet. > Please let stable@vger know when it does hit Linus's tree and we will be > glad to take it. Doh, of course, it is in next and not linus tree, now it makes sense. I'll wait a bit until it is there and revisit this, unless it gets picked automatically by the Fixes tag. Sorry for the noise. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-06-28 13:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210408230001.310215-1-marex@denx.de>
2021-06-28 10:44 ` [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM Marek Vasut
2021-06-28 12:29 ` Greg KH
2021-06-28 12:32 ` Marek Vasut
2021-06-28 13:02 ` Greg KH
2021-06-28 13:10 ` Marek Vasut
2021-06-28 13:38 ` Greg KH
2021-06-28 13:58 ` Marek Vasut
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox