From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: stable <stable@vger.kernel.org>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 5.4.y stable only] MIPS: fix "mipsel-linux-ld: decompress.c:undefined reference to `memmove'"
Date: Thu, 15 Jul 2021 13:35:39 +0200 [thread overview]
Message-ID: <YPAdi8UOhyaw0eNT@kroah.com> (raw)
In-Reply-To: <YPAaWOM1z75o21V1@B-P7TQMD6M-0146.local>
On Thu, Jul 15, 2021 at 07:22:00PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On Thu, Jul 15, 2021 at 12:52:33PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Jul 09, 2021 at 09:24:08PM +0800, Gao Xiang wrote:
> > > commit a510b616131f85215ba156ed67e5ed1c0701f80f upstream.
> >
> > That is not what this commit id is :(
> >
> > Please fix this up and be more careful.
>
> That's the exact commit, the original upstream commit was named as
> "MIPS: Add support for ZSTD-compressed kernels", which contains the
> memmove() definition so the upstream / 5.10 LTS kernel is fine.
>
> But for 5.4 LTS, we shouldn't backport the whole patch since only
> memmove() part is needed in order to fix the build regression...
That was not obvious, and is confusing :(
Please just submit the fix and say _why_ this is not an upstream commit,
do not attempt to emulate an upstream commit like your change did.
thanks,
greg k-h
next prev parent reply other threads:[~2021-07-15 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202107070120.6dOj1kB7-lkp@intel.com>
[not found] ` <YOfjmCT6n61Yidvp@B-P7TQMD6M-0146.local>
2021-07-09 7:20 ` [linux-stable-rc:linux-5.4.y 7045/7049] mipsel-linux-ld: decompress.c:undefined reference to `memmove' Gao Xiang
2021-07-09 10:31 ` Greg Kroah-Hartman
2021-07-09 13:24 ` [PATCH 5.4.y stable only] MIPS: fix "mipsel-linux-ld: decompress.c:undefined reference to `memmove'" Gao Xiang
2021-07-14 16:15 ` Gao Xiang
2021-07-15 10:52 ` Greg Kroah-Hartman
2021-07-15 11:22 ` Gao Xiang
2021-07-15 11:35 ` Greg Kroah-Hartman [this message]
2021-07-15 12:26 ` Gao Xiang
2021-07-09 13:49 ` [linux-stable-rc:linux-5.4.y 7045/7049] mipsel-linux-ld: decompress.c:undefined reference to `memmove' Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPAdi8UOhyaw0eNT@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=lkp@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox