From: Sasha Levin <sashal@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: stable@vger.kernel.org, gregkh@linuxfoundation.org,
broonie@kernel.org, "Rander Wang" <rander.wang@intel.com>,
"Bard Liao" <bard.liao@intel.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
Subject: Re: [PATCH] ASoC: Intel: boards: fix xrun issue on platform with max98373
Date: Mon, 2 Aug 2021 15:27:55 -0400 [thread overview]
Message-ID: <YQhHO6EmugpHfJGe@sashalap> (raw)
In-Reply-To: <20210802180614.23940-1-pierre-louis.bossart@linux.intel.com>
On Mon, Aug 02, 2021 at 01:06:14PM -0500, Pierre-Louis Bossart wrote:
>From: Rander Wang <rander.wang@intel.com>
>
>commit 33c8516841ea4fa12fdb8961711bf95095c607ee upstream
>
>On TGL platform with max98373 codec the trigger start sequence is
>fe first, then codec component and sdw link is the last. Recently
>a delay was introduced in max98373 codec driver and this resulted
>to the start of sdw stream transmission was delayed and the data
>transmitted by fw can't be consumed by sdw controller, so xrun happened.
>
>Adding delay in trigger function is a bad idea. This patch enable spk
>pin in prepare function and disable it in hw_free to avoid xrun issue
>caused by delay in trigger.
>
>Fixes: 3a27875e91fb ("ASoC: max98373: Added 30ms turn on/off time delay")
>BugLink: https://github.com/thesofproject/sof/issues/4066
>Reviewed-by: Bard Liao <bard.liao@intel.com>
>Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
>Signed-off-by: Rander Wang <rander.wang@intel.com>
>Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>Link: https://lore.kernel.org/r/20210625205042.65181-2-pierre-louis.bossart@linux.intel.com
>Signed-off-by: Mark Brown <broonie@kernel.org>
>---
>
>backport to stable/linux-5.13.y and stable/linux-5.12.y since upstream
>commit does not apply directly due to a rename in 9c5046e4b3e7 which
>creates a conflict.
Any objections to bringing in:
9c5046e4b3e7 ("ASoC: Intel: boards: create sof-maxim-common module")
f6081af6cf2b ("ASoC: Intel: boards: handle hda-dsp-common as a module")
to 5.13 instead? This way we'll be better aligned with upstream and
avoid this type of failures in the future.
--
Thanks,
Sasha
next prev parent reply other threads:[~2021-08-02 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 18:06 [PATCH] ASoC: Intel: boards: fix xrun issue on platform with max98373 Pierre-Louis Bossart
2021-08-02 19:27 ` Sasha Levin [this message]
2021-08-02 21:28 ` Pierre-Louis Bossart
2021-08-02 22:02 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQhHO6EmugpHfJGe@sashalap \
--to=sashal@kernel.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox