From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B5AEC432BE for ; Thu, 5 Aug 2021 19:52:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6059560F02 for ; Thu, 5 Aug 2021 19:52:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239516AbhHETwQ (ORCPT ); Thu, 5 Aug 2021 15:52:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:42746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231387AbhHETwQ (ORCPT ); Thu, 5 Aug 2021 15:52:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EF2F1610FB; Thu, 5 Aug 2021 19:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628193118; bh=qLNAUgZkv/2CaQjiAiVAWme7qWTbxF4LBxhGXtvwNc8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GSjrRcdYkm3uJQ1WpQPy/g6KAdSWB+YRBaQVa8s+rGFY/VZ/0Pam8gi19W2e77cXg ZQ5Rt2xN3XRdGa3oKw0V1S5ZddtvqhBybgfKFSoLV/C2FLh+9XkRCrlP+aVPG4sh6s phsT0tNORY8+5bvWoSoynyGDS/lBmn6rm+bxJkSA= Date: Thu, 5 Aug 2021 21:51:55 +0200 From: Greg Kroah-Hartman To: Guenter Roeck Cc: stable , Sasha Levin Subject: Re: Regressions in stable releases Message-ID: References: <20210805173922.GB3691426@roeck-us.net> <20210805194454.GA3808616@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210805194454.GA3808616@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Aug 05, 2021 at 12:44:54PM -0700, Guenter Roeck wrote: > On Thu, Aug 05, 2021 at 07:43:20PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 05, 2021 at 10:39:22AM -0700, Guenter Roeck wrote: > > > On Thu, Aug 05, 2021 at 06:19:15PM +0200, Greg Kroah-Hartman wrote: > > > > On Thu, Aug 05, 2021 at 09:11:02AM -0700, Guenter Roeck wrote: > > > > > Hi folks, > > > > > > > > > > we have (at least) two severe regressions in stable releases right now. > > > > > > > > > > [SHAs are from linux-5.10.y] > > > > > > > > > > 2435dcfd16ac spi: mediatek: fix fifo rx mode > > > > > Breaks SPI access on all Mediatek devices for small transactions > > > > > (including all Mediatek based Chromebooks since they use small SPI > > > > > transactions for EC communication) > > > > > > > > > > 60789afc02f5 Bluetooth: Shutdown controller after workqueues are flushed or cancelled > > > > > Breaks Bluetooth on various devices (Mediatek and possibly others) > > > > > Discussion: https://lkml.org/lkml/2021/7/28/569 > > > > > > > > Are either of these being tracked on the regressions list? I have not > > > > noticed them being reported there, or on the stable list :( > > > > > > > > > > I wasn't aware of regressions@lists.linux.dev. Clueless me. And this is the > > > report on the stable list, or at least that was the idea. Should I send separate > > > emails to regressions@ with details ? > > > > For regressions in Linus's tree, yes please do. I have seen many stable > > regressions also sent there as they mirror regressions in Linus's tree > > (right now there is at least one ACPI regression that hopefully will > > show up in Linus's tree soon that has hit stable as well..) > > > > > > > Unfortunately, it appears that all our testing doesn't cover SPI and Bluetooth. > > > > > > > > > > I understand that upstream is just as broken until fixes are applied there. > > > > > Still, it shows that our test coverage is far from where it needs to be, > > > > > and/or that we may be too aggressive with backporting patches to stable > > > > > releases. > > > > > > > > > > If you have an idea how to improve the situation, please let me know. > > > > > > > > We need to get tests running in kernelci on real hardware, that's going > > > > to be much more helpful here. > > > > > > > > > > Yes, I know. Of course it didn't help that our internal testing didn't catch > > > the problem until after the fact either. > > > > There will always be issues that can only be caught on real hardware, we > > are all just human. The goal is to handle them quickly when they are > > caught. > > > > I'll go revert the above commits now, thanks. > > If you do that, it needs to be done all the way to v4.19.y. 4.9.y for the first one, 4.4.y for the second. thanks, greg k-h